Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags ordering still matters #13

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Tags ordering still matters #13

merged 1 commit into from
Oct 30, 2015

Conversation

larrylv
Copy link
Contributor

@larrylv larrylv commented Oct 30, 2015

This logic is changed in commit #9c76b44b,
I encounter a weird behaviour today. After hitting
ctrl + ], I jumped to a wrong file. By reverting to
old logic which uses s:order_tags(), jumping is ok now.

$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct 19 2015 17:09:38)
MacOS X (unix) version
Included patches: 1-898
Compiled by Homebrew

This logic is changed in commit #9c76b44b,
I encounter a weird behaviour today. After hitting
`ctrl + ]`, I jumped to a wrong file. By reverting to
old logic which uses `s:order_tags()`, jumping is ok now.

```
$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct 19 2015 17:09:38)
MacOS X (unix) version
Included patches: 1-898
Compiled by Homebrew
```
@larrylv larrylv changed the title Tags ordering still matters. Tags ordering still matters Oct 30, 2015
@ivalkeen
Copy link
Owner

Thanks, I will check. Could you please also provide version of CtrlP plugin
you're using.

On Friday, 30 October 2015, Larry Lv notifications@github.com wrote:

This logic is changed in commit #9c76b44b
9c76b44
,
I encounter a weird behaviour today. After hitting
ctrl + ], I jumped to a wrong file. By reverting to
old logic which uses s:order_tags(), jumping is ok now.

$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Oct 19 2015 17:09:38)
MacOS X (unix) version
Included patches: 1-898
Compiled by Homebrew


You can view, comment on, or merge this pull request online at:

#13
Commit Summary

  • Tags ordering still matters.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#13.

With Best Regards, Ivan Tkalin

@larrylv
Copy link
Contributor Author

larrylv commented Oct 30, 2015

@ivalkeen Thanks for your quick response. I use vundle to manage my vim plugins, and update them manually once a week. The last ctrlp change is Oct 27.

➜  ~/Code/Dotfiles/vim/bundle/ctrlp.vim ruby:(2.2.3) git:(master) ✔
$ git last
commit 46168ace5b57124190ef95390b9c38c441c0c9ee
Merge: 58247bd fca32cd
Author: mattn <mattn.jp@gmail.com>
Date:   Tue Oct 27 09:41:22 2015 +0900

@ivalkeen
Copy link
Owner

@larrylv I double checked and yes, you're right, it happens for me too. Merging it. Thanks!

ivalkeen added a commit that referenced this pull request Oct 30, 2015
Tags ordering still matters
@ivalkeen ivalkeen merged commit 8eeb9fa into ivalkeen:master Oct 30, 2015
@larrylv
Copy link
Contributor Author

larrylv commented Oct 30, 2015

💖

@Konfekt
Copy link
Contributor

Konfekt commented Oct 31, 2015

Thanks! Couldn't corner it but effectively closes #12

@Konfekt
Copy link
Contributor

Konfekt commented Oct 31, 2015

Rather, the problem described in #12 is exactly that formerly solved by s:order_tags()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants