perf: add tracing tasks and regions

ivan1993spb · Apr 9, 2024 · b9bdec5 · b9bdec5
1 parent 14d200f
commit b9bdec5
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 3 deletions.
diff --git a/internal/bot/bot.go b/internal/bot/bot.go
@@ -3,6 +3,7 @@ package bot
 import (
 	"context"
 	"math/rand"
+	"runtime/trace"
 	"sync/atomic"
 	"time"
 
@@ -94,6 +95,9 @@ func (b *Bot) getMe() uint32 {
 }
 
 func (b *Bot) operate(ctx context.Context) (types.Direction, bool) {
+	ctx, task := trace.NewTask(ctx, "operate")
+	defer task.End()
+
 	if b.getState() != stateExplore {
 		return types.DirectionZero, false
 	}

diff --git a/internal/core/bot_operator.go b/internal/core/bot_operator.go
@@ -3,6 +3,7 @@ package core
 import (
 	"context"
 	"errors"
+	"runtime/trace"
 	"sync"
 	"time"
 
@@ -304,9 +305,13 @@ func (bo *botOperator) runBot(ctx context.Context, conn connect.Connection) erro
 				break
 			}
 
-			if err := bo.parser.Parse(message); err != nil {
-				log.WithError(err).Error("parse fail")
-			}
+			trace.WithRegion(ctx, "parse", func() {
+				err := bo.parser.Parse(message)
+				if err != nil {
+					// If parsing fails, we just skip the message.
+					log.WithError(err).Error("parse fail")
+				}
+			})
 		}
 
 		return nil

diff --git a/internal/core/core.go b/internal/core/core.go
@@ -2,6 +2,7 @@ package core
 
 import (
 	"context"
+	"runtime/trace"
 	"sync"
 	"time"
 
@@ -132,6 +133,9 @@ func (c *Core) preloadState(ctx context.Context) {
 }
 
 func (c *Core) applyState(ctx context.Context, state map[int]int) map[int]int {
+	ctx, task := trace.NewTask(ctx, "applyState")
+	defer task.End()
+
 	c.mux.Lock()
 	defer c.mux.Unlock()
 
@@ -196,6 +200,9 @@ func (c *Core) unsafeGetState() map[int]int {
 var ErrRequestedTooManyBots = errors.New("requested too many bots")
 
 func (c *Core) SetState(ctx context.Context, state map[int]int) (map[int]int, error) {
+	ctx, task := trace.NewTask(ctx, "SetState")
+	defer task.End()
+
 	if stateBotsNumber(state) > c.botsLimit {
 		return nil, ErrRequestedTooManyBots
 	}
@@ -272,7 +279,11 @@ func (c *Core) SetOne(ctx context.Context, gameId, bots int) (map[int]int, error
 }
 
 func (c *Core) GetState(ctx context.Context) map[int]int {
+	_, task := trace.NewTask(ctx, "GetState")
+	defer task.End()
+
 	c.mux.Lock()
 	defer c.mux.Unlock()
+
 	return c.unsafeGetState()
 }
diff --git a/internal/http/handlers/get_state_handler.go b/internal/http/handlers/get_state_handler.go
@@ -3,6 +3,7 @@ package handlers
 import (
 	"context"
 	"net/http"
+	"runtime/trace"
 
 	"github.com/ivan1993spb/snake-bot/internal/models"
 	"github.com/ivan1993spb/snake-bot/internal/utils"
@@ -25,6 +26,10 @@ func NewGetStateHandler(app AppGetState) http.Handler {
 
 func (h *GetStateHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
+
+	ctx, task := trace.NewTask(ctx, "GetStateHandler")
+	defer task.End()
+
 	ctx = utils.WithModule(ctx, "get_state_handler")
 	log := utils.GetLogger(ctx)
 

diff --git a/internal/http/handlers/set_state_handler.go b/internal/http/handlers/set_state_handler.go
@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"mime"
 	"net/http"
+	"runtime/trace"
 	"strconv"
 	"time"
 
@@ -42,6 +43,10 @@ const setStateTimeout = 200 * time.Millisecond
 
 func (h *SetStateHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	ctx := r.Context()
+
+	ctx, task := trace.NewTask(ctx, "SetStateHandler")
+	defer task.End()
+
 	ctx = utils.WithModule(ctx, "set_state_handler")
 	log := utils.GetLogger(ctx)