Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP option for the docker engine connection #93

Closed
ivanilves opened this issue Nov 1, 2017 · 7 comments
Closed

TCP option for the docker engine connection #93

ivanilves opened this issue Nov 1, 2017 · 7 comments

Comments

@ivanilves
Copy link
Owner

I think the idea from @solidnerd PR #92 should be implemented.

@solidnerd
Copy link
Collaborator

I think one of low hanging fruit would be to use client.NewEnvClient() instead of the current implementation in https://github.com/ivanilves/lstags/blob/master/docker/client/client.go#L33 .

@vonrabbe
Copy link
Collaborator

vonrabbe commented Nov 4, 2017

@ivanilves I consider this critical.

❗ We need to have tcp for docker to preload images on our swarm fleet machines. 🙏

@vonrabbe
Copy link
Collaborator

vonrabbe commented Nov 4, 2017

I propose to do this first #29 and then immediately do the TCP thing.

WDYT?

@solidnerd
Copy link
Collaborator

@ivanilves @vonrabbe I would grab me this and try to solve it if you want. I think this would gives this tool a big improvement how you can handle that.
I think #94 is not the correct way because now we are skipping the tests during a docker build and this should be not case. When we are introducing the tcp option it's also possible to have the tests during the docker build and we can revert the assemble job in the makefile.

@ivanilves
Copy link
Owner Author

You are welcome to grab this @solidnerd 💪

Yes #94 is not the best way. We just needed something to start fast and simple.

@ivanilves
Copy link
Owner Author

Hey @solidnerd did you have any time to look at this?

@ivanilves
Copy link
Owner Author

Closing this in favor of #102 (to narrow focus)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants