Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1-2-7: Some refactoring, fixes and change of defaults #198

Merged
merged 4 commits into from
Aug 27, 2019
Merged

v1-2-7: Some refactoring, fixes and change of defaults #198

merged 4 commits into from
Aug 27, 2019

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented Aug 27, 2019 •
edited

@coveralls
Copy link

coveralls commented Aug 27, 2019 •
edited

Coverage Status

Coverage remained the same at 96.102% when pulling 3f642ce on v1-2-7 into 6ced3b6 on master.

@ivanilves ivanilves changed the title refactor: put manifest routines into a separate package v1-2-7: Some refactoring and fixes Aug 27, 2019
@ivanilves ivanilves changed the title v1-2-7: Some refactoring and fixes v1-2-7: Some refactoring, fixes and change of defaults Aug 27, 2019
vonrabbe
vonrabbe reviewed Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@vonrabbe vonrabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vonrabbe vonrabbe merged commit 751ff21 into master Aug 27, 2019
@vonrabbe vonrabbe deleted the v1-2-7 branch August 27, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonrabbe vonrabbe vonrabbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivanilves @coveralls @vonrabbe