Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GH-33): Support rule loading from config file #41

Merged
merged 2 commits into from
Dec 11, 2022
Merged

feat(GH-33): Support rule loading from config file #41

merged 2 commits into from
Dec 11, 2022

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented Dec 3, 2022

Fixes #33 🎉

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #41 (d251115) into main (fbf7c60) will decrease coverage by 14.28%.
The diff coverage is 51.35%.

❗ Current head d251115 differs from pull request most recent head ebbf3bb. Consider uploading reports for the commit ebbf3bb to get more accurate results

@@             Coverage Diff              @@
##              main      #41       +/-   ##
============================================
- Coverage   100.00%   85.71%   -14.29%     
============================================
  Files           12       14        +2     
  Lines          213      252       +39     
============================================
+ Hits           213      216        +3     
- Misses           0       36       +36     
Impacted Files Coverage Δ
pkg/config/rule.go 0.00% <0.00%> (ø)
pkg/config/config.go 81.25% <66.66%> (-18.75%) ⬇️
pkg/config/include_fn.go 88.88% <88.88%> (ø)
pkg/config/include/common.go 100.00% <100.00%> (ø)
pkg/config/include/dockerfile.go 100.00% <100.00%> (ø)
pkg/config/include/groovy.go 100.00% <100.00%> (ø)
pkg/config/include/jenkinsfile.go 100.00% <100.00%> (ø)
pkg/config/include/terraform.go 100.00% <100.00%> (ø)
pkg/config/include/terragrunt.go 100.00% <100.00%> (ø)
pkg/directory/directory.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ivanilves ivanilves changed the title refactor(GH-33): pass the whole config.Config instead of just func feat(GH-33): Support rule loading from config file Dec 11, 2022
@ivanilves ivanilves added the enhancement New feature or request label Dec 11, 2022
@ivanilves ivanilves merged commit 6007859 into main Dec 11, 2022
@ivanilves ivanilves deleted the GH-33 branch December 11, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule loading from config file
2 participants