Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make autoparams work with keyword-only parameters: #26

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Make autoparams work with keyword-only parameters: #26

merged 1 commit into from
Mar 27, 2019

Conversation

cselvaraj
Copy link
Contributor

  • v3.5.0 lost some compatibility with keyword-only parameters
  • PEP8 fixes
  • sync up versions and increment to a dev version

@cselvaraj
Make autoparams work with keyword-only parameters:
8048792 
- v3.5.0 lost some compatibility with keyword-only parameters
- PEP8 fixes
- sync up versions and increment to a dev version
@ivankorobkov
Copy link
Owner

Hi. Sorry for the delay. I'll look into it tomorrow.

@ivankorobkov ivankorobkov merged commit 561e818 into ivankorobkov:master Mar 27, 2019
@ivankorobkov
Copy link
Owner

Looks good to me. Also, thanks for the code cleanup. I think, this should be released as 3.5.1, will do it this week.

@cselvaraj cselvaraj deleted the fix/autoparams-keyword-only branch March 27, 2019 22:43
@cselvaraj
Copy link
Contributor Author

Sounds good. Thanks, @ivankorobkov !

@ivankorobkov
Copy link
Owner

Released 3.5.1 https://pypi.org/project/Inject/

@ivankorobkov
Copy link
Owner

Sorry for the delay. I was a little busy these two weeks.

@cselvaraj
Copy link
Contributor Author

cselvaraj commented Apr 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cselvaraj @ivankorobkov