Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It works on Windows XP (mostly) #3

Closed
unpingco opened this issue Aug 12, 2011 · 2 comments
Closed

It works on Windows XP (mostly) #3

unpingco opened this issue Aug 12, 2011 · 2 comments
Labels

Comments

@unpingco
Copy link

I had to make the changes to the completion function to the "old" way that is documented in your code instead of the version that Min recommends:

starting from line 400:

 m = get_child_msg(msg_id)
# get rid of unicode (sporadic issue, haven't tracked down when it happens)
matches = [str(u) for u in m['content']['matches']]
# mirk sez do: completion_str = '[' + ', '.join(msg['content']['matches'] ) + ']'
# because str() won't work for non-ascii characters
#matches = m['content']['matches']
#end = len(base)
#completions = [m[end:]+findstart+base for m in matches]
matches.insert(0,base) # the "no completion" version
#echo(str(matches))
completions = matches

otherwise, it would crash when I would try to do completions and mysteriously would recognize the Ctrl+u part of the completion sequence as the letter 'u' instead of as Ctrl+u. This obviously caused a number of downstream errors that I couldn't isolate.

Great work!

@ivanov
Copy link
Owner

ivanov commented Aug 16, 2011

Thanks for the bug report, but the str version will still fail if there are unicode filenames among the completions. Please try the alternative version from the commit which will close this bug in a few minutes, and reopen the bug if it does not fix the issue for you.

@ivanov ivanov closed this as completed in 6af8474 Aug 16, 2011
@unpingco
Copy link
Author

It works!

scholi pushed a commit to scholi/vim-ipython that referenced this issue Jun 18, 2018
Make doc buffer `nomodifiable`.

The line below the line you changed has `nomodifiable` in it and is commented out but I looked through the commit history and it was like that in the initial version so who knows why it's commented out. Seems like a good idea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants