Clean up mappings: LocalLeader, Plug, and noremap #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 23, 2013 08:55
Use <LocalLeader> for filetype-specific maps so user-defined local leaders work. Recommended by :help maplocalleader
Use noremap where possible to prevent breakage when users remap certain keys. (Some people swap : and ; which would break all calls to :python)
Using noremap will ensure maps still work for users who remap core vim keys (like :). Some maps only make sense in normal mode, so only map them there.
Use <Plug> for plugin maps to make it easier for users to define their
own maps.
<Plug> names are wrapped in braces to ensure that RunLine and RunLines
aren't considered overlapping by vim. (Otherwise, vim will pause after
RunLine to make sure you don't want RunLines.) See also:
http://stackoverflow.com/questions/13688022/what-is-the-reason-to-parenthesize-plug-map-names
Plug names have common prefixes (Plot, RunLine) to make completion
easier and grouping clearer.
Note: You cannot use noremap for Plug (it won't map to anything).
Adds <buffer> to all plugin maps. Only apply the maps in the current buffer to prevent them from carrying over into nonpython buffers (where the commands wouldn't make sense).
Hide these from users since they are currently unimplemented.
|
This is a great improvement, makes the plug-in much more configurable and reliable, and less intrusive. It's also more compliant to Vim mappings standards. Why hasn't it been accepted yet @ivanov ? (Lovely work, btw, I'm very thankful for your plugin, sorry for the maybe annoying comments, I just want to help make it even better!) |
ivanov
added a commit
that referenced
this pull request
Nov 7, 2013
Clean up mappings: LocalLeader, Plug, and noremap closes #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of changes to convert vim-ipython to use common vim plugin conventions:
<Plug>mappings so all mappings can be defined by users (even ones that use<SID>functions). This makes it easier to make internal changes (like renaming python functions) without breaking user's mappings.I tried to break it up into small changes to make the diffs easier to read.