Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Scoped & Transient Lifetime #31

Closed
lilasquared opened this issue Oct 14, 2019 · 1 comment
Closed

Support Scoped & Transient Lifetime #31

lilasquared opened this issue Oct 14, 2019 · 1 comment
Assignees
@ivanpaulovich
Labels
enhancement New feature or request
Milestone
alpha

Comments

@lilasquared
Copy link

FluentMediator/src/FluentMediator.Microsoft.Extensions.DependencyInjection/FluentMediatorExtensions.cs

Line 12 in f217ba0

services.AddSingleton<IMediator>(c => mediatorBuilder.Build(c.GetService));

This will likely cause issues with complex applications relying on container scope. Would be nice to support different lifetimes. Could maybe take inspiration from
https://github.com/jbogard/MediatR.Extensions.Microsoft.DependencyInjection
@ivanpaulovich ivanpaulovich self-assigned this Oct 15, 2019
@ivanpaulovich ivanpaulovich added the enhancement New feature or request label Oct 15, 2019
@ivanpaulovich ivanpaulovich added this to the alpha milestone Oct 17, 2019
ivanpaulovich added a commit that referenced this issue Oct 19, 2019
@ivanpaulovich
Scoped and Transient lifetime added #31
4d83168
ivanpaulovich added a commit that referenced this issue Oct 19, 2019
@ivanpaulovich
Scoped and Transient lifetime added #31
6b5b6d3
@ivanpaulovich
Copy link
Owner

Fixed on #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanpaulovich ivanpaulovich

Labels
enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

No branches or pull requests
2 participants
@lilasquared @ivanpaulovich