Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules require unused extensions #199

Closed
ivanperez-keera opened this issue Mar 17, 2022 · 0 comments
Closed

Modules require unused extensions #199

ivanperez-keera opened this issue Mar 17, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
enhancement
Milestone
Yampa 0.13.4

Comments

@ivanperez-keera
Copy link
Owner

Some modules declare extensions that are not really needed in the code inside the module.

This is likely a vestige from when all code lived in one main FRP module.

Removing unnecessary extensions will make the code easier to maintain, read, and also help remove the use of unnecessary extensions in the future if possible (which would make the code more portable).
@ivanperez-keera ivanperez-keera self-assigned this Mar 17, 2022
@ivanperez-keera ivanperez-keera changed the title Unused extensions Modules require unused extensions Mar 17, 2022
ivanperez-keera added a commit that referenced this issue Mar 17, 2022
@ivanperez-keera
Remove unused language extensions. Refs #199.
1222a31 
Some modules declare GHC extensions that are not really needed in the
code inside the module. This is likely a vestige from when all code
lived in one main FRP module.

Removing unnecessary extensions will make the code easier to maintain,
read, and also help remove the use of unnecessary extensions in the
future if possible (which would make the code more portable).

This commit removes unused GHC extensions from all Yampa modules.
ivanperez-keera added a commit that referenced this issue Mar 17, 2022
@ivanperez-keera
Document changes in CHANGELOG. Refs #199.
adbb0fc 
[ci skip]
ivanperez-keera added a commit that referenced this issue Mar 17, 2022
@ivanperez-keera
Remove unused language extensions. Refs #199.
75ca6b3 
Some modules declare GHC extensions that are not really needed in the
code inside the module. This is likely a vestige from when all code
lived in one main FRP module.

Removing unnecessary extensions will make the code easier to maintain,
read, and also help remove the use of unnecessary extensions in the
future if possible (which would make the code more portable).

This commit removes unused GHC extensions from all Yampa modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
enhancement
Projects
None yet
Milestone
Yampa 0.13.4
Development

No branches or pull requests
1 participant
@ivanperez-keera