Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move regression tests into Quickcheck-based tests #208

Closed
ivanperez-keera opened this issue May 14, 2022 · 0 comments
Closed

Move regression tests into Quickcheck-based tests #208

ivanperez-keera opened this issue May 14, 2022 · 0 comments
Assignees
Milestone

Comments

@ivanperez-keera
Copy link
Owner

In an effort to progressively make the quickcheck-based tests also carry out all unit and regression testing duties in Yampa, we should move regression tests into Yampa's QC test module.

@ivanperez-keera ivanperez-keera added this to the (+1) milestone May 14, 2022
@ivanperez-keera ivanperez-keera self-assigned this May 14, 2022
ivanperez-keera added a commit that referenced this issue May 14, 2022
…#208.

In an effort to progressively make the quickcheck-based tests also carry
out all unit and regression testing duties in Yampa, we should move
regression tests into Yampa's QC test module.

This commit moves all regression tests into the YampaQC module. The
tests are removed from the regression testing module, which now only
tests for space leaks (but always exits with a success exit code).
ivanperez-keera added a commit that referenced this issue May 14, 2022
…e. Refs #208.

With the latest change, the regression testing module can only test for
space leaks. Therefore, the flags that were supposed to be used to
select whether one wanted to test for performance or regression no
longer apply, as the only meaningful action one can execute it to run
the space leak testing.

This commit simply removes all support for command line arguments,
making the test always execute the space leak tests.
ivanperez-keera added a commit that referenced this issue May 14, 2022
#208.

With the latest change, the "regression" testing suite only checks for
space tests.

This commit changes the module description to match the module's new
purpose.
ivanperez-keera added a commit that referenced this issue May 14, 2022
The old "regression" testing suite now only checks for space tests
(leaks).

This commit changes the name and test name in the package description to
match the module's new purpose.
ivanperez-keera added a commit that referenced this issue May 14, 2022
The testSpace.hs module now has become a proxy for Tests. To facilitate
that modules reflect their purpose, this commit moves all content from
the Tests module into testSpace.hs, and removes the former.
ivanperez-keera added a commit that referenced this issue May 14, 2022
The old regression testing suite now only tests for space usage.

This commit renames the flag that controls that test so that it matches
its new purpose. It also adapts the flag's description accordingly.
ivanperez-keera added a commit that referenced this issue May 14, 2022
The space usage tests require users to monitor the space consumed by the
application as they run the test.

If therefore makes no sense for that test to be ran automatically, since
most users will either be just installing Yampa, or just checking that
Yampa's tests finish successfully.

This commit makes the default status of that flag false, requiring that
users enable it manually if they really want to run the space tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant