Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency of Haskell code style - compress multiple white lines #214

Closed
ivanperez-keera opened this issue May 15, 2022 · 0 comments
Closed

Consistency of Haskell code style - compress multiple white lines #214

ivanperez-keera opened this issue May 15, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
maintenance
Milestone
Yampa 0.13.5

Comments

@ivanperez-keera
Copy link
Owner

A number of optional style suggestions were not implemented in #200 (see #200 (comment)).

Vertical space across the implementation is inconsistent. Some modules leave two spaces between definitions, others leave only one.

Our style guide includes:

4.5.1 Vertical Whitespace: always recommended
Suggestion: A single blank line should appear:

  1. Between consecutive definitions.

It therefore would be appropriate to always reduce vertical separation to one line.
@ivanperez-keera ivanperez-keera added this to the (+1) milestone May 15, 2022
@ivanperez-keera ivanperez-keera self-assigned this May 15, 2022
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
8c70d72 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
e62f38b 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
ac175a1 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
a54720c 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
f0dc1ee 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
d318a1f 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
6ee5d59 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
d30004c 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
5a90269 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
8252822 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
cac8355 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
e58f60d 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
64553d9 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
5edaf85 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
7aab7d4 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
97068fe 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
bdc24bc 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1). Refs …
d33f267 
…#214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
a4e4bc7 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
4b68c42 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
b585dca 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
5901f7b 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
b7238d9 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
9d2d577 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
27ebd4b 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
2ea91be 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
8fd378e 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
46b57d3 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
1abcc45 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
b185b21 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
0b6454e 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
54a857b 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
976b7f1 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
1294768 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
226afaa 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
62bdb82 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
8daed5f 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
232ff49 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
a11890c 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
0e4ddc9 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
9fd51ae 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
yampa-test: Compress multiple empty lines (KSG Haskell 1.3.0 - 4.5.1)…
d218790 
…. Refs #214.

Suggestion: A single blank line should appear between consecutive definitions.
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
Document changes in yampa:CHANGELOG. Refs #214.
b9d32a0
ivanperez-keera added a commit that referenced this issue May 15, 2022
@ivanperez-keera
Document changes in yampa-test:CHANGELOG. Refs #214.
8dfca19
@ivanperez-keera ivanperez-keera mentioned this issue Apr 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
maintenance
Projects
None yet
Milestone
Yampa 0.13.5
Development

No branches or pull requests
1 participant
@ivanperez-keera