Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yampa-test: Test do not compile with old GHC versions #239

Closed
ivanperez-keera opened this issue Oct 15, 2022 · 0 comments
Closed

yampa-test: Test do not compile with old GHC versions #239

ivanperez-keera opened this issue Oct 15, 2022 · 0 comments
Assignees
@ivanperez-keera
Labels
bug
Milestone
Yampa 0.14

Comments

@ivanperez-keera
Copy link
Owner

The tests use <$> and <*> but do not import them appropriately.
@ivanperez-keera ivanperez-keera added this to the (+1) milestone Oct 15, 2022
@ivanperez-keera ivanperez-keera self-assigned this Oct 15, 2022
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Imports from applicative in old GHCs. Refs #239.
cf73d8a 
The tests use <$> and <*> but do not import them appropriately in old
GHC versions, which causes compilation to fail.

This commit adds a conditional import of those definitions when using
versions of base that do not include them in the Prelude.
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Document changes in CHANGELOG. Refs #239.
c0260fa
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Imports from applicative in old GHCs. Refs #239.
300bc83 
The tests use <$> and <*> but do not import them appropriately in old
GHC versions, which causes compilation to fail.

This commit adds a conditional import of those definitions when using
versions of base that do not include them in the Prelude.
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Document changes in CHANGELOG. Refs #239.
0b8f8a3
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Explicit import from Control.Applicative with old version…
7ea5850 
…s of base. Refs #239.

The tests use <$> and <*> but do not import them appropriately in old
GHC versions, which causes compilation to fail.

This commit adds a conditional import of those definitions when using
versions of base that do not include them in the Prelude.
ivanperez-keera added a commit that referenced this issue Oct 15, 2022
@ivanperez-keera
yampa-test: Document changes in CHANGELOG. Refs #239.
6178d36
@ivanperez-keera ivanperez-keera modified the milestones: (+1), (+2) Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanperez-keera ivanperez-keera

Labels
bug
Projects
None yet
Milestone
Yampa 0.14
Development

No branches or pull requests
1 participant
@ivanperez-keera