List of available commands is incorrectly aligned #4
Comments
|
Issue was caused by the upgrade of |
|
@ivanpirog Any chance you could take a look into this regression? The upstream change looks reasonable, so may require Colored Cobra to update how it applies the template. |
|
Have a fairly simple fix to this issue: Line 158 in d040004 Change this to: tpl = re.ReplaceAllLiteralString(tpl, "{{rpad (CommandStyle .Name) (sum .NamePadding 15)}}")Will also need the unit tests updated from I will have a pull request up shortly. |
mikelorant
added a commit
to mikelorant/coloredcobra
that referenced
this issue
Apr 13, 2024
When upgrading the Color package from `v1.15.0` to `v1.16.0`, the list of available commands becomes incorrectly aligned: ```text Available Commands: completion Generate the autocompletion script for the specified shell help Help about any command test Test command for clarity ``` This was related to an [issue][1] where reset codes were not correctly set. The [fix][2], which added extra reset codes, increased the length of the string (which includes the ANSI codes) causing the amount of padding to be insufficient. This change, which upgrades the Color package to `v1.16.0`, also increass the padding to account for the additional ANSI reset codes that are now part of the string. This restores the text alignment to how it was previously displayed. Unit tests also needed to be updated to account for this change and are passing successfully. The Color package had updated its dependencies which has caused the changes in `go.mod` to impact more than itself. Fixes: ivanpirog#4 [1]: fatih/color#206 [2]: fatih/color#210 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au>
daylinmorgan
pushed a commit
to daylinmorgan/coloredcobra
that referenced
this issue
May 27, 2024
When upgrading the Color package from `v1.15.0` to `v1.16.0`, the list of available commands becomes incorrectly aligned: ```text Available Commands: completion Generate the autocompletion script for the specified shell help Help about any command test Test command for clarity ``` This was related to an [issue][1] where reset codes were not correctly set. The [fix][2], which added extra reset codes, increased the length of the string (which includes the ANSI codes) causing the amount of padding to be insufficient. This change, which upgrades the Color package to `v1.16.0`, also increass the padding to account for the additional ANSI reset codes that are now part of the string. This restores the text alignment to how it was previously displayed. Unit tests also needed to be updated to account for this change and are passing successfully. The Color package had updated its dependencies which has caused the changes in `go.mod` to impact more than itself. Fixes: ivanpirog#4 [1]: fatih/color#206 [2]: fatih/color#210 Signed-off-by: Michael Lorant <michael.lorant@nine.com.au> Signed-off-by: Daylin Morgan <me@dayl.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As visible in the screenshot below, the description of the the
helpandimagecommands is not aligned with the description of thecompletioncommand.The text was updated successfully, but these errors were encountered: