Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Encounter & Condition bundle #27

Merged
merged 5 commits into from
Mar 31, 2024

Conversation

SyaefulKai
Copy link
Collaborator

Sebelumnya metode addCondition hanya membuat conditionnya saja, tidak menambahkan referensi condition ke dalam Encounter. Sekarang condition/diagnosis sudah di referensikan di dalam Encounter.

@SyaefulKai
Copy link
Collaborator Author

Wiki updatenya bisa dilihat di sini

Copy link
Owner

@ivanwilliammd ivanwilliammd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: setelah saya cek kembali ini sepertinya masih perlu disesuaikan kembali

Perlu diperhatikan pada saat addCondition --> $encounter->addDiagnosis juga perlu ditrigger...

Sehingga usul selain public $encounter_id, public $encounter juga perlu dideklarasi

Copy link
Owner

@ivanwilliammd ivanwilliammd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    // Menambahkan diagnosis ke encounter 
     $this->encounter->addDiagnosis($condition_uuid, $condition->condition['code']['coding'][0]['code']);

Harusnya bukan $condition_uuid saja, tetapi ada prefix urn:uuid juga

Copy link
Owner

@ivanwilliammd ivanwilliammd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job :

Note - json_decode pada POST & PUT Encounter tunggal tidak dianjurkan
json_decode untuk squashing ke dalam komponen bundle sudah tepat dilakukan

Alasannya : karena Guzzle library HTTP dapat lgsg passing json object, dan tidak lagi menerima text (hasil json_decode)

@ivanwilliammd ivanwilliammd merged commit abe1060 into ivanwilliammd:main Mar 31, 2024
1 check passed
@SyaefulKai SyaefulKai deleted the feat/bundle branch April 1, 2024 17:07
@ivanwilliammd ivanwilliammd self-requested a review April 2, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants