-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Encounter & Condition bundle #27
Conversation
Wiki updatenya bisa dilihat di sini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: setelah saya cek kembali ini sepertinya masih perlu disesuaikan kembali
Perlu diperhatikan pada saat addCondition --> $encounter->addDiagnosis juga perlu ditrigger...
Sehingga usul selain public $encounter_id, public $encounter juga perlu dideklarasi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Menambahkan diagnosis ke encounter
$this->encounter->addDiagnosis($condition_uuid, $condition->condition['code']['coding'][0]['code']);
Harusnya bukan $condition_uuid saja, tetapi ada prefix urn:uuid juga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job :
Note - json_decode pada POST & PUT Encounter tunggal tidak dianjurkan
json_decode untuk squashing ke dalam komponen bundle sudah tepat dilakukan
Alasannya : karena Guzzle library HTTP dapat lgsg passing json object, dan tidak lagi menerima text (hasil json_decode)
Sebelumnya metode addCondition hanya membuat conditionnya saja, tidak menambahkan referensi condition ke dalam Encounter. Sekarang condition/diagnosis sudah di referensikan di dalam Encounter.