Use decoded_content in response logging, because gzip is unreadable for mere humans #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanwills
added a commit
that referenced
this pull request
Aug 22, 2013
|
I have applied the change, sorry it took so long to get done. |
ivanwills
added a commit
that referenced
this pull request
Aug 22, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ivan,
I ran into trouble trying to access a soap service, and couldn't really figure out how to debug at first. The response logging looked like gibberish. So I looked at how you do the debugging through WWW::Mechanize, and that module's response_done handler doesn't automatically decode gzip'ed data. I had similar difficulty passing in a log object. So I tried patching the W3C::SOAP::Client module, changed "content" to "decoded_content" in a couple of places, and there was the actual response body, logged through my own logging object! That will make debugging a lot easier in the future.
Thanks for a great set of modules!
Rhesa