-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed .wharf-ci.yml for canary builds #124
Conversation
75b1094
to
dd677d9
Compare
dd677d9
to
9fadd89
Compare
9fadd89
to
74e59a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats the use case for this?
Edit: Nvm i think it might be the continuation to the discussion over the earlier named "development" environment. I still think this would be better off tied to a specific branch rather than just tags.
Also the name unstable just seems like code for undesierable. I would preffer canary to unstable if those are the available choices.
Also i think lastest should be only prod build such that the tag moves with the actualy releases.
The planned flow is as follows:
This depends on branches and not on just tags. Or are you referring to the Docker image tag? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
CHANGELOG.md
file, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Summary
.wharf-ci.yml
to:canary
.wharf-ci.yml
Motivation
Minor tweaks to make the Wharf builds work and be able to build Wharf itself.
The image tag nameChanged to:unstable
is up for debate. Perhaps:canary
? Or simply:latest
?:canary
.Related to iver-wharf/iver-wharf.github.io#80
This is the first PR I'm marking "Ready for review". Let's have all discussions in this PR to begin with, as the other PRs listed in the meta-issue above are basically just the same.