Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed .wharf-ci.yml for canary builds #124

Merged
merged 3 commits into from
Dec 1, 2021
Merged

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Nov 22, 2021

Summary

  • Changed deploy tag in .wharf-ci.yml to :canary
  • Changed to use our internal Docker Hub registry caching proxy in Docker builds
  • Fixed Wharf build step name in .wharf-ci.yml

Motivation

Minor tweaks to make the Wharf builds work and be able to build Wharf itself.

The image tag name :unstable is up for debate. Perhaps :canary? Or simply :latest? Changed to :canary.

Related to iver-wharf/iver-wharf.github.io#80

This is the first PR I'm marking "Ready for review". Let's have all discussions in this PR to begin with, as the other PRs listed in the meta-issue above are basically just the same.

@applejag applejag self-assigned this Nov 22, 2021
@applejag applejag added the enhancement New feature or request label Nov 22, 2021
@applejag applejag added this to In progress in Backlog via automation Nov 22, 2021
@applejag applejag changed the title Updated .wharf-ci.yml Changed .wharf-ci.yml for unstable builds Nov 22, 2021
Copy link
Contributor

@fredx30 fredx30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the use case for this?
Edit: Nvm i think it might be the continuation to the discussion over the earlier named "development" environment. I still think this would be better off tied to a specific branch rather than just tags.

Also the name unstable just seems like code for undesierable. I would preffer canary to unstable if those are the available choices.

Also i think lastest should be only prod build such that the tag moves with the actualy releases.

@applejag
Copy link
Contributor Author

applejag commented Nov 22, 2021

@fredx30 /.../ I still think this would be better off tied to a specific branch rather than just tags.

The planned flow is as follows:

  1. Go to our internal wharf-web instance

  2. Find project iver-wharf/wharf-api

  3. Press start new build

  4. Select branch you want deployed
    Screenshot from 2021-11-22 11-24-56

  5. Once build has finished, find our "deploy-unstable"/"deploy-canary" project and start a new build there

  6. Done

This depends on branches and not on just tags. Or are you referring to the Docker image tag?

@applejag applejag changed the title Changed .wharf-ci.yml for unstable builds Changed .wharf-ci.yml for canary builds Nov 23, 2021
.wharf-ci.yml Show resolved Hide resolved
Backlog automation moved this from In progress to Review in progress Nov 24, 2021
Copy link
Member

@Alexamakans Alexamakans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

.wharf-ci.yml Show resolved Hide resolved
Backlog automation moved this from Review in progress to Reviewer approved Nov 29, 2021
@applejag applejag merged commit 3c0f77f into master Dec 1, 2021
Backlog automation moved this from Reviewer approved to Done Dec 1, 2021
@applejag applejag deleted the feature/wharf-build branch December 1, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants