-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added execution engine configs #134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredx30
approved these changes
Jan 31, 2022
Alexamakans
approved these changes
Feb 7, 2022
I pushed two minor bug fixes. Hope you're OK with me merging without you review again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
file, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Summary
Added config:
Added response models for engines
Added endpoint
GET /api/engine
Added query parameter
?engine=
to "start build" endpointAdded engine ID to build table
Added engine to build responses via engineLookup
Added a new problem type:
/prob/api/engine/no-default
Motivation
Allows for a more natural transition over to wharf-cmd instead of Jenkins, as the user can specify what execution engine they want to use on a per-build basis.
With such, we can have Jenkins as the primary and default engine until wharf-cmd is feature-complete with our Jenkins implementation. Then we could switch so wharf-cmd is the primary engine and keep Jenkins as a secondary to allow using that one if the wharf-cmd implementation fails.
The config design is a bit weird. The reason is that Viper, the config library we're using via wharf-core, doesn't support arbirary names or indices for environment variables. It can only perform lookups on fields it already recognizes. See #132 for the initial YAML config design using a
map[string]Engine
. This config design limits us for now to only having a primary and a secondary engine, but can be expanded further by addingci.engine3
,ci.engine4
, etc. From the REST API perspective, it's just a list of engine definitions.After merge
/prob/api/engine/no-default
Closes #132