Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go-typ #172

Merged
merged 8 commits into from
Mar 30, 2022
Merged

Added go-typ #172

merged 8 commits into from
Mar 30, 2022

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Mar 30, 2022

Summary

  • Added go-typ v3.0.1
  • Removed unused contains func
  • Replaced internal/set with typ/pkg/sets.Set
  • Changed func to generic
  • Replaced internal/coalese with typ.Coal()
  • Changed to use chans.RecvQueued()

Motivation

Simplifies some code by using existing libraries. This way if we use the same libs throughout wharf then it's easier to understand, in comparison to where all repos has their own custom code for stuff

@applejag applejag added the chore Routine task, refactoring, or other changes not affecting end-users directly. label Mar 30, 2022
@applejag applejag self-assigned this Mar 30, 2022
Copy link
Member

@Alexamakans Alexamakans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@applejag applejag merged commit da754ca into master Mar 30, 2022
@applejag applejag deleted the feature/go-typ branch March 30, 2022 12:45
@applejag applejag mentioned this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Routine task, refactoring, or other changes not affecting end-users directly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants