Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed updated build object not in response when updating build status #183

Merged
merged 3 commits into from
May 5, 2022
Merged

Fixed updated build object not in response when updating build status #183

merged 3 commits into from
May 5, 2022

Conversation

Alexamakans
Copy link
Member

Summary

  • Changed to return response.Build on successful PUT /api/build/{buildId}/status request.
    • Also changed status code to 200 (OK).

Motivation

Closes #179

@Alexamakans Alexamakans requested a review from applejag May 5, 2022 12:58
@Alexamakans Alexamakans self-assigned this May 5, 2022
@Alexamakans Alexamakans added the bug Something isn't working label May 5, 2022
applejag
applejag approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B e a utifully simple.

@Alexamakans Alexamakans merged commit 63bbaac into master May 5, 2022
@Alexamakans Alexamakans deleted the bugfix/respond-with-updated-build branch May 5, 2022 14:25
@applejag applejag mentioned this pull request May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applejag applejag applejag approved these changes

Assignees

@Alexamakans Alexamakans

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endpoint PUT /api/build/{buildId}/status should respond with updated build
2 participants
@Alexamakans @applejag