Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed path params to camelCase #76

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Changed path params to camelCase #76

merged 6 commits into from
Sep 17, 2021

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Sep 15, 2021 •
edited
Loading

Summary

  • branchid → branchId
  • projectid → projectId
  • providerid → providerId
  • tokenid → tokenId
  • buildid → buildId

I did a search and replace on all files inside the repo. No all-lowercase alternatives, except for inside the CHANGELOG.md, remain.

Motivation

Closes #68

@applejag applejag added the documentation Improvements or additions to documentation label Sep 15, 2021
@applejag applejag self-assigned this Sep 15, 2021
@applejag applejag added this to the RFC-0016 milestone Sep 15, 2021
@applejag applejag added this to In progress in Backlog via automation Sep 15, 2021
Alexamakans
Alexamakans approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@Alexamakans Alexamakans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

iverestefans
iverestefans approved these changes Sep 17, 2021
View reviewed changes
Copy link

@iverestefans iverestefans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Backlog automation moved this from In progress to Reviewer approved Sep 17, 2021
@applejag applejag merged commit 7b584c5 into master Sep 17, 2021
Backlog automation moved this from Reviewer approved to Done Sep 17, 2021
@applejag applejag deleted the feature/camelcase-path-params branch September 17, 2021 09:52
This was referenced Sep 22, 2021
Merged
Closed
@applejag applejag removed this from the RFC-0016 milestone Oct 12, 2021
@applejag applejag added this to the RFC-0016 milestone Nov 18, 2021
@applejag applejag mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredx30 fredx30 fredx30 approved these changes

@iverestefans iverestefans iverestefans approved these changes

@Alexamakans Alexamakans Alexamakans approved these changes

Assignees

@applejag applejag

Labels
documentation Improvements or additions to documentation
Projects
No open projects
Backlog
Done
Milestone
RFC-0016
Development

Successfully merging this pull request may close these issues.

Rename path parameters
4 participants
@applejag @fredx30 @iverestefans @Alexamakans