Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added repo #1

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Added repo #1

merged 1 commit into from
Jun 11, 2021

Conversation

applejag
Copy link
Contributor

@applejag applejag commented May 31, 2021

No, your eyes are not deceiving. This is a new PR with the same ID...

Our k8s cluster secret was accidentally pushed. Of all the secrets one could place in the repo... To be sure it's gone I recreated the repo, as that forces a clear of the git history, where force pushes still leave the original commits up for a short while.

Got an email from GitGuardian (https://gitguardian.com) that they detected our k8s secret. We don't even use GitGuardian, but it's their way of marketing. Quite clever.

But then the question remains, who else listened to GitHub events? Probably a lot of people.

We have to regenerate the secret. It's too risky to leave it be. Even though it's hidden under a private network.


For this PR, which closes iver-wharf/iver-wharf.github.io#32, the following changes were made:

  • No Git history
  • Removed any internal services references
  • Changed module path in go.mod

@applejag applejag added the enhancement New feature or request label May 31, 2021
@applejag applejag self-assigned this May 31, 2021
@applejag applejag added this to In progress in Backlog via automation May 31, 2021
@applejag applejag requested a review from fredx30 May 31, 2021 08:20
Backlog automation moved this from In progress to Reviewer approved Jun 10, 2021
@applejag applejag merged commit 2bff763 into master Jun 11, 2021
Backlog automation moved this from Reviewer approved to Done Jun 11, 2021
@applejag applejag deleted the feature/add-repo branch June 11, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Move remaining repos
3 participants