Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go test & goimports actions #6

Merged
merged 2 commits into from
Nov 17, 2021
Merged

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Nov 15, 2021

Summary

Motivation

Based on iver-wharf/wharf-api#106

Closes #5

@applejag applejag added the enhancement New feature or request label Nov 15, 2021
@applejag applejag self-assigned this Nov 15, 2021
@applejag applejag added this to In progress in Backlog via automation Nov 15, 2021
@applejag
Copy link
Contributor Author

Oh the tests actually fail :o

Looks like some incorrect wharf-core logger usage.

I'm not going to tackle that in this PR though. They'll have to keep on failing in master, and get fixed in a different PR.

Backlog automation moved this from In progress to Reviewer approved Nov 15, 2021
@fredx30
Copy link

fredx30 commented Nov 15, 2021

Oh the tests actually fail :o

Looks like some incorrect wharf-core logger usage.

I'm not going to tackle that in this PR though. They'll have to keep on failing in master, and get fixed in a different PR.

Why merge now if it only results in failing tests? Would it be better to re-draft it fix the issue and then merge this. That way it would come as a benefit instead of a hinderance.

@applejag
Copy link
Contributor Author

Why merge now if it only results in failing tests? Would it be better to re-draft it fix the issue and then merge this. That way it would come as a benefit instead of a hinderance.

Because I don't want to spend time on this right now, and I want to forget about it. But I can mark it as draft and open an issue about it instead

Copy link

@fredx30 fredx30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - masterplan in iver-wharf/iver-wharf.github.io#75

@applejag applejag merged commit 8d42a13 into master Nov 17, 2021
Backlog automation moved this from Reviewer approved to Done Nov 17, 2021
@applejag applejag deleted the feature/go-test-action branch November 17, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Need automated testing via go test
3 participants