Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Event.WithStringer #15

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Added Event.WithStringer #15

merged 2 commits into from
Jul 12, 2021

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Jul 5, 2021

Useful for enums and similar.

Example:

log.Info().
	WithString("level", level.String()).
	Message("Set logging level.")

// vs

log.Info().
	WithStringer("level", level).
	Message("Set logging level.")

@applejag applejag added the enhancement New feature or request label Jul 5, 2021
@applejag applejag self-assigned this Jul 5, 2021
@applejag applejag added this to In progress in Backlog via automation Jul 5, 2021
Backlog automation moved this from In progress to Reviewer approved Jul 12, 2021
@applejag applejag merged commit 885570d into master Jul 12, 2021
Backlog automation moved this from Reviewer approved to Done Jul 12, 2021
@applejag applejag deleted the feature/with-stringer branch July 12, 2021 08:09
@applejag applejag mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iverestefans iverestefans iverestefans approved these changes

@Alexamakans Alexamakans Alexamakans approved these changes

@fredx30 fredx30 Awaiting requested review from fredx30

@Grimwind Grimwind Awaiting requested review from Grimwind

@Pikabanga Pikabanga Awaiting requested review from Pikabanga

Assignees

@applejag applejag

Labels
enhancement New feature or request
Projects
No open projects
Backlog
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@applejag @iverestefans @Alexamakans