Added Codacy badge & Revive linting #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applejag
added
documentation
fredx30
approved these changes
May 25, 2021
There was a problem hiding this comment.
See the warning in azuredevops.go InsecureSkipVerify should not be used in production code. https://github.com/iver-wharf/wharf-provider-azuredevops/security/code-scanning/5?query=ref%3Arefs%2Fpull%2F9%2Fmerge
Should probably be offloaded to an investigation.
Out of scope of this PR. But IMO this should at the very least be an opt-in config instead of on by default with no opt-out ability. |
Pikabanga
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to iver-wharf/iver-wharf.github.io#47