Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows docker build #44

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Fix windows docker build #44

merged 4 commits into from
Dec 9, 2021

Conversation

fredx30
Copy link
Contributor

@fredx30 fredx30 commented Dec 8, 2021

Summary

Shebang signature modified for docker runs. Had issues on docker windows.

Motivation

This makes it easier to docker build on windows.

Also see similar changes:

@fredx30 fredx30 changed the title Make run gooder windows. Fix windows docker build Dec 8, 2021
@fredx30 fredx30 marked this pull request as ready for review December 8, 2021 17:09
@fredx30 fredx30 self-assigned this Dec 8, 2021
@fredx30 fredx30 requested review from applejag and Alexamakans and removed request for applejag December 8, 2021 17:09
@fredx30 fredx30 added the bug Something isn't working label Dec 8, 2021
@fredx30 fredx30 added this to In progress in Backlog via automation Dec 8, 2021
Backlog automation moved this from In progress to Reviewer approved Dec 9, 2021
Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
@fredx30 fredx30 merged commit 2110540 into master Dec 9, 2021
Backlog automation moved this from Reviewer approved to Done Dec 9, 2021
@fredx30 fredx30 deleted the bug/fix-windows-build branch December 9, 2021 10:37
@applejag applejag mentioned this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants