Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made wharf-api v5.0.0 compatible #45

Merged
merged 11 commits into from
Feb 7, 2022
Merged

Made wharf-api v5.0.0 compatible #45

merged 11 commits into from
Feb 7, 2022

Conversation

Alexamakans
Copy link
Member

@Alexamakans Alexamakans commented Jan 18, 2022 •
edited
Loading

Summary

Updated to use wharf-api-client-go v2.0.0, making it wharf-api v5.0.0 compatible, but dropping support for wharf-api v4.2.0 and below.

Motivation

Keep up-to-date.

Closes #7

@Alexamakans Alexamakans added the enhancement New feature or request label Jan 18, 2022
@Alexamakans Alexamakans self-assigned this Jan 18, 2022
@Alexamakans Alexamakans added this to In progress in Backlog via automation Jan 18, 2022
@Alexamakans
Copy link
Member Author

Alexamakans commented Jan 20, 2022 •
edited
Loading

Ignoring failed Codacy Static Code Analysis check, don't see any way to deduplicate it and no real reason to do so currently.

@applejag
Copy link
Contributor

Ignoring failed Codacy Static Code Analysis check, don't see any way to deduplicate it and no real reason to do so currently.

Tracked in: iver-wharf/wharf-api#89

I vote for disabling the duplication checks for PRs

@Alexamakans Alexamakans marked this pull request as ready for review January 25, 2022 08:40
@Alexamakans Alexamakans requested review from fredx30 and applejag and removed request for applejag and fredx30 January 25, 2022 08:41
@applejag applejag mentioned this pull request Jan 26, 2022
Merged
applejag
applejag approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@applejag applejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun, we're going from v2.0.0 to v3.0.0 😅

@Alexamakans Alexamakans merged commit 3338e8f into master Feb 7, 2022
@Alexamakans Alexamakans deleted the feature/make-wharf-api-v5.0.0-compatible branch February 17, 2022 15:58
@applejag applejag mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applejag applejag applejag approved these changes

@fredx30 fredx30 fredx30 approved these changes

Assignees

@Alexamakans Alexamakans

Labels
enhancement New feature or request
Projects
No open projects
Backlog
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map projects per ID: update importers code
3 participants
@Alexamakans @applejag @fredx30