Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be able to import personal projects #7

Open
applejag opened this issue May 21, 2021 · 5 comments
Open

Should be able to import personal projects #7

applejag opened this issue May 21, 2021 · 5 comments
Labels
bug Something isn't working enhancement New feature or request prio/2 Medium priority. "Good to have"
Projects

Comments

@applejag
Copy link
Contributor

Currently GitLab importer are able to import projects from selected group. When we do not indicate the group it will take all projects that user has access to including personal projects. On the list it is shown as 'username/projectname'. If someone will decide to import only personal projects an error will occur. Things to do:

  • add get list personal project functionality to git lab fetcher

  • on import group add aditional check if delivered group name is a user name. If it is a group or a username, it should be supplied as a separate input.

  • write UT to new functionality

  • Changes in frontend should be included in this task

@applejag applejag added bug Something isn't working enhancement New feature or request labels May 21, 2021
@applejag applejag added this to To do in Backlog via automation May 21, 2021
@applejag applejag added prio/1 Low priority. "Nice to have" prio/2 Medium priority. "Good to have" and removed prio/1 Low priority. "Nice to have" labels Jan 18, 2022
@Alexamakans
Copy link
Member

Alexamakans commented Jan 19, 2022

Possibly closed by changes 92052ac and 1c32a44 in #43?

Edit: Per discussion below, not closed by #43.

@applejag
Copy link
Contributor Author

@Alexamakans Possibly closed by changes 92052ac and 1c32a44 in #43?

Idk, you're the author :P You tell me

@Alexamakans
Copy link
Member

Alexamakans commented Jan 19, 2022

@Alexamakans Possibly closed by changes 92052ac and 1c32a44 in #43?

Idk, you're the author :P You tell me

Unsure what is meant by personal projects here, and if it is retrieved differently from "normal" projects or not.
And if the frontend changes have been implemented and whatnot.

Probably should have added that in my previous comment 🦘

@applejag
Copy link
Contributor Author

applejag commented Jan 19, 2022

@Alexamakans IIRC then this is only an issue when importing projects in Wharf from GitLab with the group specified but not the project name.

For example:

Probably because if not supplying a project name when importing via Wharf, it performs a group project listing, when it instead should be a little smarter and do a user project listing if the specified Wharf group ends up being a GitLab user.

@applejag
Copy link
Contributor Author

And if the frontend changes have been implemented and whatnot.

That part of the issue description I cannot vouch for. I am not the original author of this issue, as it was a work order that was copied over from our previously used issue tracker/ITSM ("The Cure").

I do not see any need for any frontend changes. Rather that the wharf-provider-gitlab deals with the two alternative Wharf group type abstraction instead of like adding a <select> input field to wharf-web for "GitLab user" contra "GitLab group"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request prio/2 Medium priority. "Good to have"
Projects
No open projects
Backlog
To do
Development

No branches or pull requests

2 participants