-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made wharf-api v5.0.0 compatible #43
Made wharf-api v5.0.0 compatible #43
Conversation
Currently runnable with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to me as if this could be redrafted untill the testing issue i resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking as "request changes" again to get it out of our PR tracker as still expecting changes
Fixed tests. No coverage increase. Due to changes in the code, coverage % has decreased. There should be no change to the paths that are tested though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lunchbreak between reviews, will continue to review later
Co-authored-by: kalle (jag) <kalle.fagerberg@iver.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit hard to review- not entierly sure why or how some of these changes came about but if its tested im sure it will be fine.
Mainly projects with spaces in their names broke, but I think it's also possible for the actual path to be different from the display name. Added a fallback to search for the project by name and comparing This will also affect refreshing those projects, until logic for remote project IDs is implemented anyways. |
Co-authored-by: kalle (jag) <kalle.fagerberg@iver.se>
CHANGELOG.md
file, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
CHANGELOG.md
entry with the correctwharf-api-client-go
version.Related issue: (gitlab api/v4) search_namespaces option fails with error 500 from GitLab #42
Summary
Updated to use
wharf-api-client-go v2.0.0
, making itwharf-api v5.0.0
compatible, but dropping support forwharf-api v4.2.0
and below.The testing code has not been updated and is therefore not functional currently. See Unresolved questions.
Motivation
Keep up-to-date.
Resolved questions
If we want to keep it the way it is (updated so it works) then I can spend time updating it.
Otherwise I will remove it, and we can come back to it when we have decided on how we want to write our tests.
Should we spend time updating it, or remove it for now?
Closes #6, closes #42