Defend from error on invalid URL #6
Conversation
|
I'm not sure we should silently swallow this problem. An invalid URL is something that would need to be fixed, and by not showing an error we don't know that there's a problem. |
| ? new URL(this.project.provider.url).hostname | ||
| : null; | ||
| } catch (e) { | ||
| this.providerHostname = null; |
There was a problem hiding this comment.
@Pikabanga brings a fair point. Would rather see a PrimeNG tag with the tooltip of "Invalid provider URL: {error message}" and then setting this.providerHostname = this.project.provider.url directly.
Ex:
| NAME | GROUP | PROVIDER | STATUS | ACTIONS |
|---|---|---|---|---|
| sample1 | default | [error] /some/invalid-url |
N/A | ... |
| sample2 | default | github.com | N/A | ... |
There was a problem hiding this comment.
Ah I wonder if there was a misunderstanding here @fredx30. I meant an [error] tag to the table itself, for when an invalid host name was inserted by other means, such as from an invalid importer path, instead of just hiding the invalid hostname.
|
Consider implementing validator (#8 (comment)) |
fredx30
force-pushed
the
bug/defend-invalid-url
branch
from
e382984
to
74423bc
Compare
|
There is still an error here regarding code duplication. As this is currently executed codeduplication is bordeline unavoidable. I think a solution to the code duplication would be to get started on dynamic forms. And then using them to describe the differences between the 3 providers using a configuration object such as the model to pass in. |
src/app/providers/provider-form/azuredevops/azuredevops.component.ts
Outdated
Show resolved
Hide resolved
src/app/providers/provider-form/azuredevops/azuredevops.component.html
Outdated
Show resolved
Hide resolved
…lab and azuredevops forms
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
fredx30
force-pushed
the
bug/defend-invalid-url
branch
from
0ecc5e4
to
2027d31
Compare
|
Resolved conflicts on changelog with rebase. |
|
Created an issue (#37) on to deal with the form duplication warned about here- https://app.codacy.com/gh/iver-wharf/wharf-web/pullRequest?prid=7476842&bid=23686990 |
Bug Fix - Invalid URLs
This fixes an issue where an invlid URL set on a project produces an error.
This is solved by silencing the error that occurs when the constructor fornew URL(...)fails.Edit:
This is solved by introducing form validation with form locking on invalid input for all the provider forms. Additionally they way URLs get processed has changed see- #6 (comment) -
Example validation failed.
Example validation passed-
