Authentication #70
Merged
Authentication #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredx30
commented
Sep 15, 2021
fredx30
force-pushed
the
feature/auth
branch
from
50969ed
to
1f65a33
Compare
fredx30
force-pushed
the
feature/auth
branch
2 times, most recently
from
0bac919
to
1cca6f6
Compare
fredx30
commented
Oct 28, 2021
2 tasks
fredx30
force-pushed
the
feature/auth
branch
7 times, most recently
from
94af961
to
369a74b
Compare
Alexamakans
reviewed
Dec 10, 2021
There was a problem hiding this comment.
Checked for big picture stuff.
I'm not very well-versed in angular/OIDC things, but to me the logic and structure looks solid 👍🏻
Not going to approve per-request, will do more thorough review on request :)
Will also check back now and then between doing other things to see if I notice anything 👍🏻
fredx30
force-pushed
the
feature/auth
branch
from
621f642
to
677af74
Compare
applejag
reviewed
Jan 10, 2022
applejag
suggested changes
Jan 10, 2022
applejag
suggested changes
Jan 18, 2022
applejag
approved these changes
Feb 15, 2022
While working with https://web.dev/cross-origin-resource-sharing/#share-credentials-with-cors type requests i realised that 'Access-Control-Allow-Origin: *' was not allowed. I have not yet found a great way of handling these headers with angular. This seems the best way- however it does not seem compatible with our current config.
Based on motivation from #101: The rfc4648.js author was kind enough to publish an update with the license: swansontec/rfc4648.js#18 This makes `npm run collect-licenses` work.
This reverts commit f567df1.
Merged
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdfile, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Although we may consider making this a major change instead of a patch to make it easier to track this inclusion.
Summary
This adds authentication to the frontend. While this change in itself does not cause any breaking change its a fairly big version change. When the backend is set to validate OIDC tokens this branch is required as it allows the sending of OIDC tokens which will bypass the unauthorised issued that occurs otherwise.
Introduces pages/routes:
We should consider implementing some of the following:
Motivation
Authentication is a requested feature. See more about the initial plan and requirements set fourth by the RFC 13 - Authentication