Regened rest clients #91
Conversation
wharf-api v5.0.0-rc.1, wharf-provider-github v2.0.0, wharf-provider-gitlab v1.2.0, wharf-provider-azuredevops v2.0.1
wharf-api v5.0.0, wharf-provider-github v2.0.0, wharf-provider-gitlab v1.3.0, wharf-provider-azuredevops v2.0.1
There was a problem hiding this comment.
LGTM!
Regarding this discussion: #91 (comment)
I think it's better to turn that into an issue and deal with it in a different PR.
Also: the PR description is outdated.
| @@ -54,7 +54,7 @@ export class ActionsModalComponent implements OnInit, OnDestroy { | |||
| if (this.actionName === this.projectUtilsService.runAllActionName) { | |||
| this.actionName = 'ALL'; | |||
| } | |||
| this.projectService.projectProjectidStageRunPost( | |||
| this.projectService.oldStartProjectBuild( | |||
There was a problem hiding this comment.
I was worried about breaking compatibility, but hey we mostly only do GET requests from wharf-web (which have barely changed), with the exception of this POST build request. Very nice!
There was a problem hiding this comment.
We need to be careful though once we start using wharf-api v5.0.0-specific query parameters or endpoints. Maybe we should (in a different issue & PR) just do a major version bump and switch to using the new endpoints, so that we don't trip on this.
Co-authored-by: kalle (jag) <kalle.jillheden@iver.se>
Created issue for this: #105 |
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
nit: intresting whitepace here
There was a problem hiding this comment.
Yeah, same as before it's an artifact of the swagger code generation.
Possibly a stylistic choice by them 🤷🏻♂️
There was a problem hiding this comment.
Correct. They've a bunch of if-statements in their templates, such as:
{{ if foo }}
foo!
{{ end }}
{{ if bar }}
bar!
{{ end }}
{{ if moo }}
moo!
{{ end }}Which if none of foo, bar, or moo is set, then it results in 3 empty lines. One for each newline between the {{ end }} and next {{ if }} statements.
CHANGELOG.mdfile, according to docs:https://iver-wharf.github.io/#/development/changelogs/writing-changelogs
Summary
Motivation
Keep up-to-date.
Closes #73