Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tooltips #2

Closed
ugurdogrusoz opened this issue Jul 28, 2016 · 2 comments
Closed

Disable tooltips #2

ugurdogrusoz opened this issue Jul 28, 2016 · 2 comments
Assignees

Comments

@ugurdogrusoz
Copy link
Contributor

Tooltips might be used to provide help on the menu items but the users might prefer to disable them. Maybe an option to disable them if not needed?

metincansiper added a commit that referenced this issue May 28, 2017
By suggestion of @grigorijski at #8
metincansiper added a commit that referenced this issue May 28, 2017
This reverts commit da15b7f.
@metincansiper
Copy link
Collaborator

@ugurdogrusoz the I considered the suggestion in #8 it works to disable tooltips, but then I realized that you want this to be optional and I reverted that change for now.

I think that instead of an option to disable tooltips globally or per menu item we may have an option called 'tooltip' or 'title' (Currently 'title' is the option name we use to set the content of each menu item I think that is misleading and we need to change the name of this option as 'content' because in html/css context 'title' sets the tooltip rather then content. However, changing it may require a major release.) and if this option is set it will determine the tooltip of the menu item, if it is not set then the menu item will not have a tooltip. In this way users will be able to set titles fof menu items other then their content.

If you accept it I can do in this way.

metincansiper added a commit that referenced this issue May 28, 2017
@metincansiper
Copy link
Collaborator

I make the changes that I mentioned in the previous comment. I named the option, previously named as "title", as "content". I added "tooltipText" option which determines the tooltip text of a menu item. If it is not set for a menu item then that menu item does not have a tooltip. After making these changes I relased v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants