Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift components to original location on layout #47

Closed
ugurdogrusoz opened this issue Jul 12, 2021 · 1 comment
Closed

Shift components to original location on layout #47

ugurdogrusoz opened this issue Jul 12, 2021 · 1 comment
Assignees

Comments

@ugurdogrusoz
Copy link
Contributor

When fCoSE runs, it might shift the center of the drawing arbitrarily (see this similar issue in CiSE for an example; this is due to problems in our force model). In order to avoid this, we should calculate the center of the drawing before layout and move the laid-out drawing back to this location. This should be the case for each individual component if packing is enabled. This is already done in non-incremental layout but should be done for incremental one as well.

@hasanbalci hasanbalci self-assigned this Oct 14, 2021
hasanbalci added a commit that referenced this issue Oct 18, 2021
Shift components to original location on layout
@hasanbalci
Copy link
Contributor

@ugurdogrusoz We now shift graph to its original location in both randomized and incremental layout. If packing is enabled, we first shift each individual component to its original location, then apply packing.

I added fit option to both demo.html and demo-compound.html files so that we can test whether the graph stays in its original location after layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants