Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop during packing #11

Closed
hasanbalci opened this issue Oct 15, 2019 · 3 comments
Closed

Infinite loop during packing #11

hasanbalci opened this issue Oct 15, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@hasanbalci
Copy link
Contributor

I was trying to pack two disconnected nodes and realized that sometimes code runs into infinite loop. I think it's this loop in which the cells variable becomes 0 and cannot find placement. A sample case can be found here.

@hasanbalci hasanbalci added the bug Something isn't working label Oct 15, 2019
nasimsaleh added a commit that referenced this issue Oct 16, 2019
@nasimsaleh nasimsaleh assigned hasanbalci and unassigned nasimsaleh Oct 16, 2019
@ugurdogrusoz
Copy link
Contributor

@hasanbalci Pls check

@hasanbalci
Copy link
Contributor Author

In this sample case, I give the positions of edge's source and target nodes as the edge start and end points instead of using edge's bounding box since it's more convenient in my case. Packing either takes too much time or runs into infinite loop and I think it sticks around on this for loop.

@hasanbalci hasanbalci reopened this Apr 8, 2020
@ugurdogrusoz ugurdogrusoz assigned nasimsaleh and unassigned hasanbalci Apr 9, 2020
nasimsaleh added a commit that referenced this issue Apr 9, 2020
@nasimsaleh nasimsaleh assigned ugurdogrusoz and unassigned nasimsaleh Apr 9, 2020
@hasanbalci
Copy link
Contributor Author

It's working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants