Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for more levels before a decision #6

Closed
ugurdogrusoz opened this issue Sep 2, 2019 · 3 comments
Closed

Search for more levels before a decision #6

ugurdogrusoz opened this issue Sep 2, 2019 · 3 comments
Assignees

Comments

@ugurdogrusoz
Copy link
Contributor

ugurdogrusoz commented Sep 2, 2019

Looks like we should try more neighboring levels for a good location to place the next polyomino before we make a decision. Otherwise, this is more or less the first closest place that works. Maybe at least maximum of half of width and height (# of squares) of the bounding box of the polyomino.

@nasimsaleh
Copy link
Contributor

@ugurdogrusoz I already pushed it before seeing the created issue here.
43916e1

@ugurdogrusoz
Copy link
Contributor Author

ugurdogrusoz commented Sep 2, 2019

Works nicely. One more improvement could be as follows. Among all those locations yielding the same adjusted fullness, looks like we're settling for an arbitrary one. Shouldn't we settle for the one yielding the biggest fullness?
For example same graph with d.a.r. of 1.25:
125

vs. d.a.r. of 1.50:
150

With the latter, we're wasting space unnecessarily, as the former clearly shows that there is a better packing with the same adjusted fullness.

Let's discuss.

@ugurdogrusoz ugurdogrusoz reopened this Sep 2, 2019
@ugurdogrusoz ugurdogrusoz removed their assignment Sep 2, 2019
nasimsaleh added a commit that referenced this issue Sep 3, 2019
@nasimsaleh
Copy link
Contributor

@ugurdogrusoz Now it is changed to look first at Adjusted Fullness, and if equal then Fullness and finally to the closer aspect ratio. However, the result might not change because in the example above the desired aspect ratio is different so the adjusted fullness will also be different because adjusted fullness = f(d.a.r)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants