Zig support improvement #602

ivmai · 2023-12-25T16:17:46Z

Issue #602 (bdwgc).

ivmai · 2024-01-09T08:14:04Z

@plajjan It would be very convenient to support CFLAGS_EXTRA option, could you please add it?
See CMakeLists.txt and Makefile.direct for the reference. (I'm not sure we need to separate the arguments in CFLAGS_EXTRA.)

plajjan · 2024-01-10T08:33:54Z

With "replace -Denable_threads=false to -fsingle-threaded", do you mean we should replace the user visible input? I don't think that is possible. I think the idea with zig build is that you don't just let users pass compiler flags straight to the compiler but rather expose them as project specific options (the -D options) and then set compiler flags based on that.

If on the other hand you mean that we should set -fsingle-threaded based on -Denable_threads=false, that should certainly be possible. Zig compilation objects, i.e. libraries and executable, have a single_threaded option on them, that we should probably set. I think that implies -fsingle-threaded down the line.

plajjan · 2024-01-10T08:36:53Z

@ivmai yes, I can add a simple CFLAGS_EXTRA option that just passes through its value to the compiler. I don't see any added value in parsing it to separate arguments etc, so straight pass-through it is! :)

ivmai · 2024-01-10T10:14:04Z

With "replace -Denable_threads=false to -fsingle-threaded", do you mean we should replace the user visible input? I don't think that is possible. I think the idea with zig build is that you don't just let users pass compiler flags straight to the compiler but rather expose them as project specific options (the -D options) and then set compiler flags based on that.

If on the other hand you mean that we should set -fsingle-threaded based on -Denable_threads=false, that should certainly be possible. Zig compilation objects, i.e. libraries and executable, have a single_threaded option on them, that we should probably set. I think that implies -fsingle-threaded down the line.

I mean expose change build.zig to let client build single-threaded library using -fsingle-threaded option (more nature way in zig world if I understand it correctly) instead of -Denable_threads=false option. I.e.:
zig build -fsingle-threaded instead of zig build -Denable_threads=false.
If this possible. Not a big deal, of course.

ivmai · 2024-01-10T10:28:57Z

Similarly, it looks like -Dbuild_tests option is redundant (to build and run the tests we need to pass both this option and test). I think it worth to remove build_tests option.

plajjan · 2024-01-10T12:30:04Z

@ivmai I'm no authoritative zig expert but as far as I know this is not possible. zig build-exe supports -fsingle-threaded but this is for compiling a single zig module / .c into an executable. It is similar to invoking cc directly. With zig build we use zig as a build system and not as a direct compiler, so we are expected to control things like single-threaded through code in build.zig and based on that pass down parameters to the compiler.

Just testing zig build -fsingle-threaded is invalid...

kll@Boxy:~/terastream/acton-deps/bdwgc$ ~/kod/zig/zig-linux-x86_64-0.12.0-dev.2105+60094cc3f/zig build -fsingle-threaded
Unrecognized argument: -fsingle-threaded
...

ivmai · 2024-01-10T14:38:54Z

Okay (about -fsingle-threaded). I am removing it from issue description.

ivmai · 2024-01-10T14:43:10Z

@plajjan Could we make test names as given in cmake script? (hugetest, subthreadcreatetest, etc.)

ivmai · 2024-01-10T16:33:48Z

@ivmai yes, I can add a simple CFLAGS_EXTRA option that just passes through its value to the compiler. I don't see any added value in parsing it to separate arguments etc, so straight pass-through it is! :)

It seems that cmake's separate_arguments() is needed, see #607 (comment)

ivmai · 2024-01-10T17:57:20Z

Similarly, it looks like -Dbuild_tests option is redundant (to build and run the tests we need to pass both this option and test). I think it worth to remove build_tests option.

@plajjan I will remove this option. If you agree it is redundant.

ivmai · 2024-01-11T05:42:43Z

@plajjan Could we make test names as given in cmake script? (hugetest, subthreadcreatetest, etc.)

I'll do it.

Issue #602 (bdwgc). The tests are built only if "test" step is requested (similar to Makefile), thus no need for the build_tests option. * build.zig (build_tests): Remove option (const); assume it is always true; add comment.

Issue #602 (bdwgc). * README.md (Zig): Update sample zig build command to run the tests as well.

Issue #602 (bdwgc). * build.zig (build): Pass specific filename to each addTest() call. * build.zig (addTest): Add filename argument instead of computing it from testname.

Issue #602 (bdwgc). If MISSING_MACH_O_GETSECT_H is defined (manually), then do not include mach-o/getsect.h file. * dyn_load.c [DARWIN]: Do not include getsect.h if MISSING_MACH_O_GETSECT_H. * dyn_load.c [DARWIN && MISSING_MACH_O_GETSECT_H] (getsectiondata): Declare extern function. * dyn_load.c [DARWIN] (GC_MACH_HEADER): Move definition upper (to be before getsectiondata() declaration).

Issue #602 (bdwgc).

kassane · 2024-04-13T23:41:16Z

Taking advantage of the Zig toolchain topic.
I haven't seen any reference about libc++ yet as it is statically linked by default in Zig on all LLVM targets.

What is the level of support between C++ ABI?

plajjan · 2024-04-14T10:16:12Z

@kassane when I built C++ things with Zig I have had to add .linkLibCpp() to my build.zig to get it working, doesn't that mean libc++ is not linked in per default?

kassane · 2024-04-14T12:54:00Z

Yes. By adding -lc++ or .linkLibCpp() it is linked by default to llvm-libcxx (static only).

So, bdwgc supports it has no restriction in C++ABI. Right?
If there was any favoring the GNU ABI (libstdc++) it might be problematic.

ivmai · 2024-04-15T18:08:38Z

So, bdwgc supports it has no restriction in C++ABI?

Right. It should not, at least.

ivmai · 2024-04-16T07:38:17Z

It would be good to add building of libgccpp.so, libgctba.so and cpptest to build.zig (at least to have a working sample of C++ support).

kassane · 2024-04-17T18:44:03Z

also, add msvc support using zig-build.

// zig v0.12.0 - for C++ build on msvc or gnu

// https://github.com/ziglang/zig/issues/5312
if (exe.rootModuleTarget().abi != .msvc)
    exe.linkLibCpp() // libc++ + libunwind [static]
else
    exe.linkLibC(); // search VSCrt + winSDK

kassane · 2024-04-18T16:12:27Z

It would be good to add building of libgccpp.so, libgctba.so and cpptest to build.zig (at least to have a working sample of C++ support).

~~My sample: kassane/bdwgc-d@9944b65~~
~~CI: https://github.com/kassane/bdwgc-d/actions/runs/8741234879~~

New (mix C++/D)
Sample: kassane/bdwgc-d@5bed7c8
CI: https://github.com/kassane/bdwgc-d/actions/runs/8742595019

Issue #602 (bdwgc). The final version of zig v0.12.0 has been released recently. * build.zig (zig_min_required_version): Update to "0.12.0"; remove TODO item.

(refactoring) Issue #602 (bdwgc). * build.zig (build): Rename lib variable to gc one. * build.zig (addTest): Rename lib argument to gc one.

Issue #602 (bdwgc). This commit adds support of build_cord option to Zig script (to match that of CMake script). * build.zig (build): Add build_cord const (option); define cord variable. * build.zig [build_cord] (build): Define cord_src_files variable; specify source files and dependency library for cord; install cord artifact; call addTestExt() for cordtest; add TODO item about de. * build.zig [install_headers && build_cord] (build): Install cord headers. * build.zig (addTestExt): New function (move most code from addTest except for added lib2 argument). * build.zig (addTest): Redirect to addTestExt().

ivmai · 2024-04-27T06:34:00Z

Colleagues, I've added build of cord library (7201f3f) - the code is work, but maybe you could suggest me tips to improve the code if any (cordtest request linking against 2 libs, so I've added addTestExt to be able to pass 2 libs for a test).

…t arm (fix of commit 7201f3f) Issue #602 (bdwgc). * build.zig [build_cord && enable_werror && !enable_threads && (t.abi==.gnueabi || t.abi==.gnueabihf || t.abi==.musleabi || t.abi==.musleabihf)] (build): Define AO_DISABLE_GCC_ATOMICS macro; add TODO item.

(refactoring) Issue #602 (bdwgc). * build.zig (build): Use append() instead of appendSlice() for source_files, flags, gctba_src_files where only 1 element is appended.

ivmai added the feature-request label Dec 25, 2023

ivmai added a commit that referenced this issue Dec 31, 2023

GH Actions: Cross-compile by Zig for dozens of targets

17eefee

Issue #602 (bdwgc).

plajjan mentioned this issue Jan 10, 2024

zig: Add cflags_extra option #607

Closed

plajjan mentioned this issue Jan 10, 2024

Test zig build on MacOS too #609

Closed

ivmai added a commit that referenced this issue Jan 11, 2024

Document briefly how to test libgc using Zig

7355fb4

Issue #602 (bdwgc). * README.md (Zig): Update sample zig build command to run the tests as well.

ivmai added a commit that referenced this issue Jan 12, 2024

GH Actions: Specify zig version in a dedicated field

f9251a4

Issue #602 (bdwgc).

ivmai added a commit that referenced this issue Jan 12, 2024

GH Actions: Add zig cross-compilation for MacOS (with a workaround)

9eae294

Issue #602 (bdwgc).

ivmai mentioned this issue Jan 12, 2024

Zig warning of "large atomic operation may incur significant performance penalty" on 32-bit arm #610

Open

kassane mentioned this issue Apr 17, 2024

bdwgc: zig-build msvc target - missing gnu header kassane/bdwgc-d#1

Closed

kassane mentioned this issue Apr 19, 2024

zig-msvc target error: 'unistd.h' file not found #635

Closed

ivmai added a commit that referenced this issue Apr 24, 2024

Update build.zig to support zig v0.12.0 final

d6d25a8

Issue #602 (bdwgc). The final version of zig v0.12.0 has been released recently. * build.zig (zig_min_required_version): Update to "0.12.0"; remove TODO item.

ivmai added a commit that referenced this issue Apr 27, 2024

Rename lib variable in Zig script to match CMake script

acd55a3

(refactoring) Issue #602 (bdwgc). * build.zig (build): Rename lib variable to gc one. * build.zig (addTest): Rename lib argument to gc one.

ivmai closed this as completed Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zig support improvement #602

Zig support improvement #602

ivmai commented Dec 25, 2023 •

edited

ivmai commented Jan 9, 2024

plajjan commented Jan 10, 2024

plajjan commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

plajjan commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 11, 2024

kassane commented Apr 13, 2024

plajjan commented Apr 14, 2024

kassane commented Apr 14, 2024 •

edited

ivmai commented Apr 15, 2024

ivmai commented Apr 16, 2024

kassane commented Apr 17, 2024

kassane commented Apr 18, 2024 •

edited

ivmai commented Apr 27, 2024

Zig support improvement #602

Zig support improvement #602

Comments

ivmai commented Dec 25, 2023 • edited

ivmai commented Jan 9, 2024

plajjan commented Jan 10, 2024

plajjan commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

plajjan commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 10, 2024

ivmai commented Jan 11, 2024

kassane commented Apr 13, 2024

plajjan commented Apr 14, 2024

kassane commented Apr 14, 2024 • edited

ivmai commented Apr 15, 2024

ivmai commented Apr 16, 2024

kassane commented Apr 17, 2024

kassane commented Apr 18, 2024 • edited

ivmai commented Apr 27, 2024

ivmai commented Dec 25, 2023 •

edited

kassane commented Apr 14, 2024 •

edited

kassane commented Apr 18, 2024 •

edited