Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid postion - index conversion in view #1130

Closed
ivmartel opened this issue Mar 18, 2022 · 1 comment
Closed

Avoid postion - index conversion in view #1130

ivmartel opened this issue Mar 18, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

These conversion could lead to rounding errors, resulting in, for example, the rejection of a setCurrentPosition which would then not draw the image at that position. This is what is happening in dwv-jqmobile/issues/79 (no scroll).

The view must work internally with index and only take position from external, such as the binding between layers.

@ivmartel ivmartel added the enhancement New feature or request label Mar 18, 2022
@ivmartel ivmartel added this to the 0.31.0 milestone Mar 18, 2022
@ivmartel
Copy link
Owner Author

...but using an index means you are dependent on the geometry, if it changes, the index is not correct any more. This can happen during load, a first geometry is created for the first slice and it can be updated with other coming slices. The slice is displayed correctly but a scroll will lead to a completely different position.

This change must be reverted and another solution found for ivmartel/dwv-jqmobile#79.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant