Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string dataid, replace loadid with dataid #1460

Closed
ivmartel opened this issue Jul 28, 2023 · 0 comments
Closed

Use string dataid, replace loadid with dataid #1460

ivmartel opened this issue Jul 28, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone
0.33.0

Comments

@ivmartel
Copy link
Owner

A string id seems less error prone than a simple number index and allows for more complex id in the future.
The loadid is already always equal to the dataid, best to merge both.
@ivmartel ivmartel added the enhancement New feature or request label Jul 28, 2023
@ivmartel ivmartel added this to the 0.33.0 milestone Jul 28, 2023
@ivmartel ivmartel changed the title Use string dataId, replace loadid with dataid Use string dataid, replace loadid with dataid Jul 28, 2023
ivmartel added a commit that referenced this issue Aug 3, 2023
@ivmartel
Fix index handling, relates to #1460
8ec5f36
@ivmartel ivmartel mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.33.0
Development

No branches or pull requests
1 participant
@ivmartel