Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image does not completely fill div #1655

Closed
ivmartel opened this issue Apr 17, 2024 · 1 comment
Closed

Image does not completely fill div #1655

ivmartel opened this issue Apr 17, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
0.32.5

Comments

@ivmartel
Copy link
Owner

The previous version (0.31) used to make the image fill the container div when v0.32 creates stripes.

image

If the div does have a zero height, the viewer should use the same ratio as for the width and stretch the div to fill it completely.

Originates from: https://wordpress.org/support/topic/a-few-0-10-2-issues/
@ivmartel ivmartel added the bug Something isn't working label Apr 17, 2024
@ivmartel ivmartel added this to the 0.32.5 milestone Apr 17, 2024
ivmartel added a commit that referenced this issue Apr 17, 2024
@ivmartel
Resize div if no height, fixes #1655
4a68a43
@ivmartel
Copy link
Owner Author

Fixed in 4a68a43.

ivmartel added a commit that referenced this issue Apr 18, 2024
@ivmartel
Resize div if no height, relates to #1655
63fd64f
ivmartel added a commit that referenced this issue Jun 6, 2024
@ivmartel
Squashed commit of the following:
677e076 
commit deff835
Merge: 3ec2e61 5ac76df
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 19:47:08 2024 +0200

    Merge branch 'v0.32'

commit 5ac76df
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 19:45:50 2024 +0200

    Release 0.32.6

commit 3ec2e61
Merge: 042253e 9b8da76
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 19:35:06 2024 +0200

    Merge branch 'v0.32'

commit 9b8da76
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 19:34:01 2024 +0200

    Update build to 0.32.5

commit 042253e
Merge: 085f3db 7786d92
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 18:38:37 2024 +0200

    Merge branch 'v0.32'

commit 7786d92
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 18:24:33 2024 +0200

    Release 0.32.5

commit 4a68a43
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Apr 17 18:06:42 2024 +0200

    Resize div if no height, fixes #1655

commit 085f3db
Merge: f7522e9 84dc309
Author: ivmartel <ivmartel@gmail.com>
Date:   Mon Mar 18 12:27:08 2024 +0100

    Merge branch 'v0.32'

commit 84dc309
Author: ivmartel <ivmartel@gmail.com>
Date:   Mon Mar 18 12:23:43 2024 +0100

    Release 0.32.4

commit b969c92
Author: ivmartel <ivmartel@gmail.com>
Date:   Mon Mar 18 12:07:28 2024 +0100

    Add preventDefault for wheel handler, fixes #1632

commit c4b4f6a
Author: ivmartel <ivmartel@gmail.com>
Date:   Fri Sep 22 10:11:37 2023 +0200

    Release 0.32.3

commit 51e4326
Author: ivmartel <ivmartel@gmail.com>
Date:   Thu Sep 21 09:54:37 2023 +0200

    Treat unknown vr as UN, fixes #1505

commit 4dc492c
Author: ivmartel <ivmartel@gmail.com>
Date:   Mon Sep 4 14:06:38 2023 +0200

    Update doc examples

commit f7522e9
Author: ivmartel <ivmartel@gmail.com>
Date:   Mon Sep 4 12:11:21 2023 +0200

    Release 0.32.2

commit f47ab35
Author: ivmartel <ivmartel@gmail.com>
Date:   Thu Aug 31 12:00:51 2023 +0200

    Add constuctor for colourmap

commit aff9457
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Aug 30 13:32:54 2023 +0200

    Fix typo in method name (toogle -> toggle)

commit 3d825b1
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Aug 30 13:30:08 2023 +0200

    Add constructor and update doc for WriterRule

commit 9b72102
Author: ivmartel <ivmartel@gmail.com>
Date:   Wed Aug 23 14:46:27 2023 +0200

    More doc types

commit eae25e7
Author: ivmartel <ivmartel@gmail.com>
Date:   Tue Aug 22 17:37:49 2023 +0200

    Fix lint jsdoc warnings

commit 73351c0
Author: ivmartel <ivmartel@gmail.com>
Date:   Tue Aug 22 16:40:43 2023 +0200

    Add undefined in doc for option tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.32.5
Development

No branches or pull requests
1 participant
@ivmartel