Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypedArray slice implementation for signed data #275

Closed
ivmartel opened this issue Oct 2, 2016 · 0 comments
Closed

Add TypedArray slice implementation for signed data #275

ivmartel opened this issue Oct 2, 2016 · 0 comments
Labels
enhancement New feature or request
Milestone
0.17.0

Comments

@ivmartel
Copy link
Owner

ivmartel commented Oct 2, 2016

When browsers do not provide the TypedArray slice method, dwv adds a local one to the prototypes of unsigned TypedArrays. It must provide one for signed types too.
@ivmartel ivmartel added the enhancement New feature or request label Oct 2, 2016
@ivmartel ivmartel added this to the 0.17.0 milestone Oct 2, 2016
ivmartel added a commit that referenced this issue Oct 2, 2016
@ivmartel
Revert "Add signed TypedArray slice. Fixes #275."
d0cd09b 
This reverts commit 6e2ff6d.
ivmartel added a commit that referenced this issue Oct 2, 2016
@ivmartel
Back to old slice without using array.slice.
7bc9fb8 
Relates to #275. The code was failing the tests on travis.
ivmartel added a commit that referenced this issue Oct 3, 2016
@ivmartel
Back to old slice without using array.slice.
a5c8174 
Relates to #275. The code was failing the tests on travis.
@ivmartel ivmartel mentioned this issue Jan 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
1 participant
@ivmartel