Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support for RGB images #29

Closed
ivmartel opened this issue May 1, 2013 · 5 comments
Closed

Proper support for RGB images #29

ivmartel opened this issue May 1, 2013 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ivmartel
Copy link
Owner

ivmartel commented May 1, 2013

RGB images can be loaded from DICOM and displayed but the contrast does not work on them.
RGB images should also be loaded properly from jpeg or png,

@jap1968
Copy link
Contributor

jap1968 commented May 1, 2013

I do not think that making brightness / contrast adjustments to RGB images makes sense.
In particular, there is a discussion about applying "presentation states" to RGB images, and the answer (from David Clunie among others) is definitely not to do that:

https://groups.google.com/forum/?fromgroups=#!topic/comp.protocols.dicom/FUfh28r6b0Y

@jap1968
Copy link
Contributor

jap1968 commented May 1, 2013

Anyway, that does not mean that dealing with RGB images is working at 100%. There are things that still need to be modified. When you click with the mouse pointer in the image, the software obtains the value of the HU without taking into account the "samples per pixel" condition. The system reads the value corresponding to a very different position.
That should be changed to display the RGB value (or just nothing at all) for the proper X,Y coordinates. Apart from that, I do not think Hounsfield units make sense on RGB images.

@ivmartel
Copy link
Owner Author

ivmartel commented May 3, 2013

About the presentation state, I understand what you mean Jose, I just need a bit more reading to make up my mind. In the meantime I activated it to see what it would be like.

@ivmartel
Copy link
Owner Author

ivmartel commented May 6, 2013

Moved to milestone 0.4.0.

@ivmartel
Copy link
Owner Author

ivmartel commented Sep 3, 2013

Moved to milestone 0.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants