Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with wado url loading #537

Closed
frickt opened this issue Aug 9, 2018 · 2 comments
Closed

issues with wado url loading #537

frickt opened this issue Aug 9, 2018 · 2 comments
Labels
question Further information is requested
Milestone

Comments

@frickt
Copy link
Contributor

frickt commented Aug 9, 2018

I've 2 issues when loading the images through wado requests.
my requests for "dwvApp.loadURLs(...);" looks something like this:
["./api/wado/1.3.6.1.4.1.19291.2.1.1.9999999997/1.3.6.1.4.1.24930.16748744.5900.8888/1.3.6.1.4.1.24930.02651849.7945.5872?frameNumber=1&contentType=image/jpeg", "./api/wado/1.3.6.1.4.1.19291.2.1.1.9999999997/1.3.6.1.4.1.24930.16748744.5900.8888/1.3.6.1.4.1.24930.02651849.7945.5872?frameNumber=1&contentType=image/jpeg", ...]

  1. the DicomDataLoader gets loaded before RawImageLoader and because the url does not have a extension the DicomDataLoader loads the jpeg images and fails. I can reorder the Loaders so that RawImageLoader comes first but I think it would be better if DicomDataLoader.canLoadUrl would check for contentType and retrun false if !application/dicom

  2. the RawImageLoader.load function waits on the onload function of the Image, unfortunately the function does not get called in Internet Explorer, do you have a workaround for that?

btw: very nice dicom web viewer.

@ivmartel ivmartel added the question Further information is requested label Aug 9, 2018
@ivmartel ivmartel added this to the 0.24.0 milestone Aug 9, 2018
@ivmartel
Copy link
Owner

ivmartel commented Aug 9, 2018

  1. Seems to make sense, I'll see what I can do.
  2. Ahhh, IE... does it give an error? It must be some functionality the library uses that is not available in IE
  3. Thanks!

@frickt
Copy link
Contributor Author

frickt commented Aug 10, 2018

I've fixed the IE bug in PR may be you could use some code of it.

frickt added a commit to frickt/dwv that referenced this issue Aug 21, 2018
ivmartel added a commit that referenced this issue Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants