Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null first buffer element at image contruction #712

Closed
ivmartel opened this issue Mar 16, 2020 · 0 comments
Closed

Null first buffer element at image contruction #712

ivmartel opened this issue Mar 16, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
0.27.1

Comments

@ivmartel
Copy link
Owner

The Image class guesses the number of components using the first element of the image buffer (see image.js#L143). This element could be null, it would be best to get the first non null element.
@ivmartel ivmartel added the bug Something isn't working label Mar 16, 2020
@ivmartel ivmartel added this to the 0.28.0 milestone Mar 16, 2020
@ivmartel ivmartel mentioned this issue Mar 16, 2020
Open
@ivmartel ivmartel modified the milestones: 0.28.0, 0.27.1 May 16, 2020
ivmartel added a commit that referenced this issue Sep 21, 2020
@ivmartel
Use first non null buffer instead of first one. Add array find. Fixes #…
627990d 
…712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.27.1
Development

No branches or pull requests
1 participant
@ivmartel