Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower dependency updated: DecoderScripts included #385

Closed
wants to merge 1 commit into from
Closed

Bower dependency updated: DecoderScripts included #385

wants to merge 1 commit into from

Conversation

ivanhuay
Copy link

related to #383

The only change was that the ext folder was deleted from the ignored files of bower.json

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.772% when pulling 8b73e58 on gravadigital:master into 2814238 on ivmartel:master.

@ivmartel ivmartel added the enhancement New feature or request label Sep 3, 2017
@ivmartel ivmartel added this to the 0.21.0 milestone Sep 3, 2017
@ivmartel
Copy link
Owner

ivmartel commented Sep 3, 2017

I was thinking of moving the decoder scripts to a specific folder since they are a bit different from the other dependencies. That way I would still exclude 'ext' but include the decoder folder with bower. Would that be ok with you?

@ivanhuay
Copy link
Author

ivanhuay commented Sep 4, 2017

Yes, that's fine. that way it will solve my problem. Thanks

@ivmartel
Copy link
Owner

ivmartel commented Sep 4, 2017

Instead of not excluding 'ext', the decoders were moved to their own folder in defb3ed.

@ivmartel ivmartel closed this Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants