Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

133 multi slice view #989

Merged
merged 54 commits into from
Sep 3, 2021
Merged

133 multi slice view #989

merged 54 commits into from
Sep 3, 2021

Conversation

ivmartel
Copy link
Owner

@ivmartel ivmartel commented Sep 2, 2021

⚠️ Major breaking change! ⚠️

Fixes #133. Adds a stage class to handle multiple layer groups. Adds ids to layers to find them, update events to include the source layer, change tools logic so that they find the layer. Add binder classes to bind layerGroups between each other.

The app configuration has changed to support these multi layers, see the demo viewer in the test folder for an example.

Other important changes:

  • Fix iterator and perpendicular view creation -> ⚠️ change the slice sorting order
  • Improve handling of layers with no view orientation
  • Deprecate getElement method, finding associated divs is the client responsibility
  • Simplify the layer fiting to the configured div
  • Move position change from the window level tool to the scroll tool.
  • Only send one event for window level center and/or width change

@ivmartel
Add opacity change event
45f45a9
@ivmartel
Add loadId to load controller
84c3573
@ivmartel
Add load try catch
47fbcde
@ivmartel
Store multiple loaders, add first item flag, merge load functions
0f23a0b
@ivmartel
Separate div by id in getSize, add deprecated
9a413de
@ivmartel
Update error message
e208fa5
@ivmartel
Add stage class, use it in app, update layer group
ff1bb52
@ivmartel
Update test pages
79a520e
@ivmartel
Update doc
a2ed738
@ivmartel
Use view config to setup stage
0b2f7a9
@ivmartel
Merge branch develop
57191a3
@ivmartel
Allow to set orientation from view config
136eebc
@ivmartel
Make tool retrieve layerGroup using event target (html element) id
a8c0fe3 
Rename app get layer group to get active layer group
@ivmartel
Fix layer group display to index method passing to toolbox
1444527 
Change app set tool to set tool on all layer groups
@ivmartel
Fix method call
c840b3b
@ivmartel
BREAKING: change the slice sort order, udpate iterator and tests
4e00a24
@ivmartel
Switch position change from window level to scroll tool
d1ee1e8
@ivmartel
Add position and offset binders.
8673e79
@ivmartel
Update test viewer
1b7fb65
@ivmartel
Move size check to array multiply
334b0c6
@ivmartel
Add getOrientedArray3D function
74557fe
@ivmartel
Add missing event
24649e2
@ivmartel
Fix string extraction
a96175c
@ivmartel
Add getId method to layers
5aec013
@ivmartel
Add a method to get the scroll index
d8ad46a
@ivmartel
Make layerGroup store orientation matrices
e92c174
@ivmartel
Store callbacks to allow removing listeners
906180c
@ivmartel
Add a method to get the current scroll position
e4ff000
@ivmartel
Remove unused method
5801629
@ivmartel
Make layer group handle 3d scale and offset, update tool, add helpers
bdf4080
@ivmartel ivmartel added the enhancement New feature or request label Sep 2, 2021
@ivmartel ivmartel added this to the 0.30.0 milestone Sep 2, 2021
@coveralls
Copy link

coveralls commented Sep 2, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 44.27% when pulling 4a01406 on 133-multi-slice-view into 3ad67a6 on develop.

@ivmartel ivmartel merged commit c13352e into develop Sep 3, 2021
@ivmartel ivmartel deleted the 133-multi-slice-view branch September 3, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.

Multi-slice view
2 participants
@ivmartel @coveralls