Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and Update PR version/date #53

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Fix typos and Update PR version/date #53

merged 5 commits into from
Jun 1, 2021

Conversation

gmantele
Copy link
Collaborator

This PullRequest includes:

  • few typo corrections
  • update of the ADQL and SQL reserved keywords in the text (not in the BNF though it should probably be....which will be done anyway when changing the grammar for PEG in the next version of ADQL)
  • remove the Appendix C about Outstanding Issues ; I think it is now better to rely on the GitHub Issues mechanism instead of keeping a static list of issues in an IVOA document
  • update the PR version

When this PullRequest is merged, I plan to publish the new PR in the IVOA Documents. After that the RFC could start.

@gmantele
Fix typos and update list of SQL and reserved keywords in the text.
07c0de1 
The SQL reserved keywords seem to include all ADQL keywords in common with SQL.
That's fine for the moment. Both lists will probably be largely simplified when
using a PEG grammar.
@gmantele
Fix bib reference for the IVOA note about the VO Architecture diagram.
e98160c 
Why? Because `ivoatex` does not yet include this bibref by default.
@gmantele
Remove the Appendix C about Outstanding Issues. Use the GitHub Issue …
6cc462c 
…mechanism

instead.
@gmantele
Update PR version.
4e1da4f
@gmantele gmantele added the enhancement New feature or request label May 28, 2021
@gmantele gmantele added this to the 2.1 milestone May 28, 2021
@gmantele gmantele added this to In progress in ADQL-2.1 via automation May 28, 2021
ADQL-2.1 automation moved this from In progress to Reviewer approved May 28, 2021
jd-au
jd-au previously approved these changes May 28, 2021
View reviewed changes
ADQL.tex Outdated Show resolved Hide resolved
ADQL.tex Show resolved Hide resolved
ADQL.tex Outdated Show resolved Hide resolved
ADQL-2.1 automation moved this from Reviewer approved to Review in progress May 28, 2021
ADQL-2.1 automation moved this from Review in progress to Reviewer approved May 29, 2021
@gmantele gmantele merged commit 0d5911f into ivoa-std:master Jun 1, 2021
ADQL-2.1 automation moved this from Reviewer approved to Done Jun 1, 2021
@gmantele gmantele deleted the adql_pr_20210528 branch June 1, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zarquan Zarquan Zarquan left review comments

@jd-au jd-au jd-au approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ADQL-2.1
  
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gmantele @Zarquan @jd-au