Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additional coordinate system information #97

Merged
merged 5 commits into from Sep 22, 2023
Merged

Fix additional coordinate system information #97

merged 5 commits into from Sep 22, 2023

Conversation

gmantele
Copy link
Collaborator

Following comments (5), (6) and (7) of @msdemlei in the ADQL-2.1 RFC page, here are few fixes about the usage of the coordinate system argument.

Basically:

  • remove the section Utility functions ; it just duplicated what was said in section COORDSYS, DISTANCE, POINT, ...
  • rename the section COORDSYS into Coordinate system in order to avoid confusion with the section speaking about the COORDSYS function
  • rephrase the section Coordinate system and include explanations about DISTANCE, CONTAINS and INTERSECTS
  • remove explanations from the sections about DISTANCE, CONTAINS and INTERSECTS about automatic coordinates conversion ; reference the section Coordinate system instead

@gmantele
Remove section "Utility functions".
199b031 
It was duplicating information given in the
sections DISTANCE and COORDSYS.
@gmantele
Rename Coordsys section into Coordinate System
d129e93 
The aim of this change is to avoid confusion
with the COORDSYS section speaking about
the COORDSYS() function.
@gmantele
Fix explanations about coordinate conversion
078a0f7 
in `DISTANCE`, `CONTAINS` and `INTERSECTS`.

The explanations about the deprecated parameter COOSYS
have been rephrased for more clarity.
@gmantele gmantele added the enhancement New feature or request label Sep 22, 2023
@gmantele gmantele added this to the 2.1 milestone Sep 22, 2023
@gmantele gmantele self-assigned this Sep 22, 2023
@gmantele gmantele added this to In progress in ADQL-2.1 via automation Sep 22, 2023
msdemlei
msdemlei approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made a few minor comments -- feel free to disregard them, and if you honour them, feel free to force-merge afterward, because I'll be on holiday next week and hence I may be really slow to review.

ADQL.tex Outdated Show resolved Hide resolved
ADQL.tex Outdated Show resolved Hide resolved
ADQL.tex Outdated Show resolved Hide resolved
@gmantele gmantele merged commit ad3d5cc into ivoa-std:master Sep 22, 2023
1 check passed
ADQL-2.1 automation moved this from In progress to Done Sep 22, 2023
@gmantele gmantele deleted the coord-sys-fix branch October 12, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdemlei msdemlei msdemlei approved these changes

Assignees

@gmantele gmantele

Labels
enhancement New feature or request
Projects
ADQL-2.1
  
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmantele @msdemlei