Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section references to the 1.1 changes section #105

Merged
merged 2 commits into from Jun 22, 2023

Conversation

jd-au
Copy link
Member

@jd-au jd-au commented Jun 21, 2023

The section references in the ADQL standard changelog were very helpful when reviewing but should also be useful when updating implementations, so I thought it would be good to add them to Datalink

Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, yes this is useful for readers. I've requested a couple of minor corrections to the actual crossreference targets.

DataLink.tex Outdated
\item INFO element with standardID mandatory in \blinks\ response
for different IDs in the same service (see Section \ref{sec:localSemantics})
\item relax content-type usage to allow any valid VOTable MIME type (see Section
\ref{sec:mime})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reference here should actually be to sec 3.3 not 3.1 (sec:successfulRequests).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction, change made.

DataLink.tex Outdated Show resolved Hide resolved
@jd-au jd-au merged commit 62687f5 into ivoa-std:master Jun 22, 2023
1 check passed
@jd-au jd-au deleted the jd-rfc-review branch June 22, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants