Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use utf-8 for author accents; switch Makefile to PR for upload #11

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

tomdonaldson
Copy link
Contributor

While preparing the document for PR status, I realized that the accents in an author's name were not being rendered correctly in html format. Instead of using the inputenc Latex package, I just typed the accented letters using utf-8 directly into moc.html. This seems to work for both the pdf and html renderings.

This PR also includes the Makefile updates for submitting the doc as a PR.

@mbtaylor
Copy link
Member

mbtaylor commented Nov 1, 2021

The UTF8 characters you've inserted seem to give the right result in HTML and PDF for my LaTeX installation at least ... but this looks like it might be an ivoatex issue. The LaTeX-standard accent escapes (\'{e} etc) work correctly in normal text, but not in \author macro arguments. Can @msdemlei comment?

@tomdonaldson
Copy link
Contributor Author

The UTF8 characters you've inserted seem to give the right result in HTML and PDF for my LaTeX installation at least ... but this looks like it might be an ivoatex issue. The LaTeX-standard accent escapes (\'{e} etc) work correctly in normal text, but not in \author macro arguments. Can @msdemlei comment?

I agree, and probably should have also filed an issue on https://github.com/ivoa-std/ivoatex. I want to clarify though that both of the current '{e} style accents were working in the pdf, just not in the html.

My little bit of reading shows that there may be some inconsistency in handling UTF-8 across LaTex implementations, but that the trend is toward supporting it. For this, it is working on my Mac for both pdf and html.

@msdemlei
Copy link
Contributor

msdemlei commented Nov 2, 2021 via email

Fixed a typo in the text
@tomdonaldson
Copy link
Contributor Author

Thanks @msdemlei. We'll keep the UTF-8 characters here for now, and I'll file an issue on ivoatex.

For completeness, I'll go ahead and transcribe the editorial comments to the RFC. Ada has already addressed the most obvious one.

@msdemlei
Copy link
Contributor

msdemlei commented Nov 2, 2021

Oh, and I'll do a PR for the Verbatim thing.

@AdaNebot
Copy link
Member

AdaNebot commented Nov 2, 2021

Thanks @tomdonaldson and @msdemlei. I edited the main file directly for the typo, then before continuing with modifications I thought that I'd check in with you back. I guess that for the verbatim issue, a separate PR is the way to go.

@tomdonaldson
Copy link
Contributor Author

Thanks @tomdonaldson and @msdemlei. I edited the main file directly for the typo, then before continuing with modifications I thought that I'd check in with you back. I guess that for the verbatim issue, a separate PR is the way to go.

Thanks, @AdaNebot . I agree a separate PR is best for anything else.

@AdaNebot AdaNebot self-requested a review November 2, 2021 16:18
Copy link
Member

@AdaNebot AdaNebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to merging this PR, for other issues raised here we will have separate PRs.

@AdaNebot AdaNebot merged commit 43036c8 into ivoa-std:master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants